Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891240 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(tchollingsworth@g | |mail.com) --- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Summary OK. TODO: Description might be longer. Consider something as: "This Node.JS module is a JavaScript implementation of the standard Unix 'which' command. It tells you which XXX will be run when you do MAGIC" (I am not familiar with the MAGIC, you might be :P) MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. $ rpmlint ../SRPMS/nodejs-which-1.0.5-3.fc18.src.rpm ../RPMS/noarch/nodejs-which-1.0.5-3.fc18.noarch.rpm nodejs-which.noarch: W: only-non-binary-in-usr-lib nodejs-which.noarch: W: dangling-relative-symlink /usr/bin/which.nodejs ../node_modules/bin/which nodejs-which.noarch: W: no-manual-page-for-binary which.nodejs 2 packages and 0 specfiles checked; 0 errors, 3 warnings. FIX: Bad symlink: /usr/bin/which.nodejs ../node_modules/bin/which Should link to ../lib/node_modules/... I suppose ../lib/node_modules/which/bin/which TODO: Consider working with upstream to add a manpage. All others are false positive. MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK MUST: The package must meet the Packaging Guidelines. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. Checked in LICENSE: MIT. OK MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK MUST: The spec file must be written in American English. OK MUST: The spec file for the package MUST be legible. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. $ sha256sum ../SOURCES/which-1.0.5.tgz e26f39d7b152c700636472ab4da57bfb9af17972c49a9e2a06f9ff347d8fad42 ../SOURCES/which-1.0.5.tgz $ spectool -g nodejs-which.spec Getting http://registry.npmjs.org/which/-/which-1.0.5.tgz to ./which-1.0.5.tgz $ sha256sum which-1.0.5.tgz e26f39d7b152c700636472ab4da57bfb9af17972c49a9e2a06f9ff347d8fad42 which-1.0.5.tgz OK MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. OK, builds in mock MUST: Packages must NOT bundle copies of system libraries. OK MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. OK MUST: A Fedora package must not list a file more than once in the spec file's %files listings. OK MUST: Permissions on files must be set properly. $ rpm -q -lv -p ../RPMS/noarch/nodejs-which-1.0.5-3.fc18.noarch.rpm lrwxrwxrwx 1 root root 25 led 10 20:41 /usr/bin/which.nodejs -> ../node_modules/bin/which drwxr-xr-x 2 root root 0 led 10 20:41 /usr/lib/node_modules/which drwxr-xr-x 2 root root 0 led 10 20:41 /usr/lib/node_modules/which/node_modules -rw-r--r-- 1 root root 435 bře 2 2012 /usr/lib/node_modules/which/package.json -rw-r--r-- 1 root root 3002 bře 2 2012 /usr/lib/node_modules/which/which.js drwxr-xr-x 2 root root 0 led 10 20:41 /usr/share/doc/nodejs-which-1.0.5 -rw-r--r-- 1 root root 1092 zář 23 2011 /usr/share/doc/nodejs-which-1.0.5/LICENSE -rw-r--r-- 1 root root 199 srp 7 2011 /usr/share/doc/nodejs-which-1.0.5/README.md Perms OK FIX: There is no /usr/lib/node_modules/which/bin/which ! MUST: Each package must consistently use macros. OK MUST: The package must contain code, or permissable content. OK MUST: If a package includes something as %doc, it must not affect the runtime of the application. OK MUST: Packages must not own files or directories already owned by other packages. OK MUST: All filenames in rpm packages must be valid UTF-8. OK SHOULD: The reviewer should test that the package builds in mock. OK SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. OK Please, solve FIXes and consider solving TODOs. Package NEEDSWORK. Additional question: Is the which.nodejs filename somehow documented, or you've made it up? Wouldn't which-nodejs or nodejs-which be better? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pSX7wsyUpx&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review