Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891197 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(tchollingsworth@g | |mail.com) --- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Description and Summary OK. MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. $ rpmlint ../SRPMS/nodejs-init-package-json-0.0.7-2.fc18.src.rpm ../RPMS/noarch/nodejs-init-package-json-0.0.7-2.fc18.noarch.rpm nodejs-init-package-json.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsi nodejs-init-package-json.noarch: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsi nodejs-init-package-json.noarch: W: only-non-binary-in-usr-lib nodejs-init-package-json.noarch: W: dangling-symlink /usr/lib/node_modules/init-package-json/node_modules/read-package-json /usr/lib/node_modules/read-package-json nodejs-init-package-json.noarch: W: dangling-symlink /usr/lib/node_modules/init-package-json/node_modules/read /usr/lib/node_modules/read nodejs-init-package-json.noarch: W: dangling-symlink /usr/lib/node_modules/init-package-json/node_modules/promzard /usr/lib/node_modules/promzard nodejs-init-package-json.noarch: W: dangling-symlink /usr/lib/node_modules/init-package-json/node_modules/semver /usr/lib/node_modules/semver 2 packages and 0 specfiles checked; 0 errors, 7 warnings. All are false positive. Symlinks OK, package requires (among others) npm(read-package-json), npm(semver), npm(promzard), npm(read). OK MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK MUST: The package must meet the Packaging Guidelines. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. Checked in package.json: BSD. OK MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK MUST: The spec file must be written in American English. OK MUST: The spec file for the package MUST be legible. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. $ sha256sum ../SOURCES/init-package-json-0.0.7.tgz 49bb2b928df52c81ae832afa97c7ded5e63a9cd9062109c06bd864e055e99386 ../SOURCES/init-package-json-0.0.7.tgz $ wget https://registry.npmjs.org/init-package-json/-/init-package-json-0.0.7.tgz --no-check-certificate $ sha256sum init-package-json-0.0.7.tgz 49bb2b928df52c81ae832afa97c7ded5e63a9cd9062109c06bd864e055e99386 init-package-json-0.0.7.tgz OK FIX: The Source0 URL should use http, not https MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. OK, builds in mock MUST: Packages must NOT bundle copies of system libraries. OK MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. OK MUST: A Fedora package must not list a file more than once in the spec file's %files listings. OK MUST: Permissions on files must be set properly. $ rpm -q -lv -p ../RPMS/noarch/nodejs-init-package-json-0.0.7-2.fc18.noarch.rpm drwxr-xr-x 2 root root 0 led 10 20:20 /usr/lib/node_modules/init-package-json -rw-r--r-- 1 root root 4695 lis 8 00:00 /usr/lib/node_modules/init-package-json/default-input.js -rw-r--r-- 1 root root 3048 čec 24 10:16 /usr/lib/node_modules/init-package-json/init-package-json.js drwxr-xr-x 2 root root 0 led 10 20:20 /usr/lib/node_modules/init-package-json/node_modules lrwxrwxrwx 1 root root 30 led 10 20:20 /usr/lib/node_modules/init-package-json/node_modules/promzard -> /usr/lib/node_modules/promzard lrwxrwxrwx 1 root root 26 led 10 20:20 /usr/lib/node_modules/init-package-json/node_modules/read -> /usr/lib/node_modules/read lrwxrwxrwx 1 root root 39 led 10 20:20 /usr/lib/node_modules/init-package-json/node_modules/read-package-json -> /usr/lib/node_modules/read-package-json lrwxrwxrwx 1 root root 28 led 10 20:20 /usr/lib/node_modules/init-package-json/node_modules/semver -> /usr/lib/node_modules/semver -rw-r--r-- 1 root root 719 lis 8 00:00 /usr/lib/node_modules/init-package-json/package.json drwxr-xr-x 2 root root 0 led 10 20:20 /usr/share/doc/nodejs-init-package-json-0.0.7 -rw-r--r-- 1 root root 1169 čen 17 2012 /usr/share/doc/nodejs-init-package-json-0.0.7/README.md -rw-r--r-- 1 root root 362 čen 17 2012 /usr/share/doc/nodejs-init-package-json-0.0.7/example.js OK MUST: Each package must consistently use macros. OK MUST: The package must contain code, or permissable content. OK MUST: If a package includes something as %doc, it must not affect the runtime of the application. OK MUST: Packages must not own files or directories already owned by other packages. OK MUST: All filenames in rpm packages must be valid UTF-8. OK SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. TODO: Query the upstream to include LICENSE file. SHOULD: The reviewer should test that the package builds in mock. OK SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. OK TODO: There are tests in the package, why not run them in %check section? In case you do this, don't forget to add all required modules (tap) as BRs. Please, solve FIX and consider solving TODOs. Package NEEDSWORK. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LVTO92a8kc&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review