[Bug 891190] nodejs-fstream - Advanced file system stream things

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891190

Miro Hrončok <mhroncok@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(tchollingsworth@g
                   |                            |mail.com)

--- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
Description and Summary OK.

MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.

$ rpmlint ../SRPMS/nodejs-fstream-0.1.21-2.fc18.src.rpm
../RPMS/noarch/nodejs-fstream-0.1.21-2.fc18.noarch.rpm
nodejs-fstream.src: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-fstream.src: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-fstream.src: W: spelling-error %description -l en_US symlink -> slinky
nodejs-fstream.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-fstream.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-fstream.noarch: W: spelling-error %description -l en_US symlink ->
slinky
nodejs-fstream.noarch: W: only-non-binary-in-usr-lib
nodejs-fstream.noarch: W: dangling-symlink
/usr/lib/node_modules/fstream/node_modules/mkdirp /usr/lib/node_modules/mkdirp
nodejs-fstream.noarch: W: dangling-symlink
/usr/lib/node_modules/fstream/node_modules/graceful-fs
/usr/lib/node_modules/graceful-fs
nodejs-fstream.noarch: W: dangling-symlink
/usr/lib/node_modules/fstream/node_modules/rimraf /usr/lib/node_modules/rimraf
nodejs-fstream.noarch: W: dangling-symlink
/usr/lib/node_modules/fstream/node_modules/inherits
/usr/lib/node_modules/inherits
2 packages and 0 specfiles checked; 0 errors, 11 warnings.

All are false positive. Symlinks OK, package requires (among others)
npm(graceful-fs), npm(inherits), npm(mkdirp), npm(rimraf). OK

MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines.
MUST: The License field in the package spec file must match the actual license.

FIX: License in spec is MIT, but LICENSE file says BSD.

MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. OK
MUST: The spec file must be written in American English. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.

$ sha256sum ../SOURCES/fstream-0.1.21.tgz 
31ebe4997ffdf91cb6542a5067c4226ab301292e3d87c79da539c828403022ca 
../SOURCES/fstream-0.1.21.tgz
$ spectool -g nodejs-fstream.spec 
$ sha256sum fstream-0.1.21.tgz 
31ebe4997ffdf91cb6542a5067c4226ab301292e3d87c79da539c828403022ca 
fstream-0.1.21.tgz

OK

MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. OK
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. OK, builds in mock
MUST: Packages must NOT bundle copies of system libraries. OK
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. OK
MUST: Permissions on files must be set properly.

$ rpm -q -lv -p ../RPMS/noarch/nodejs-fstream-0.1.21-2.fc18.noarch.rpm 
drwxr-xr-x    2 root    root                        0 led 10 19:41
/usr/lib/node_modules/fstream
-rw-r--r--    1 root    root                     1120 lis 19  2011
/usr/lib/node_modules/fstream/fstream.js
drwxr-xr-x    2 root    root                        0 led 10 19:41
/usr/lib/node_modules/fstream/lib
-rw-r--r--    1 root    root                     2210 pro 28 01:57
/usr/lib/node_modules/fstream/lib/abstract.js
-rw-r--r--    1 root    root                     1652 pro 28 01:57
/usr/lib/node_modules/fstream/lib/collect.js
-rw-r--r--    1 root    root                     6394 pro 28 01:57
/usr/lib/node_modules/fstream/lib/dir-reader.js
-rw-r--r--    1 root    root                     4504 pro 28 01:57
/usr/lib/node_modules/fstream/lib/dir-writer.js
-rw-r--r--    1 root    root                     3861 pro 28 01:57
/usr/lib/node_modules/fstream/lib/file-reader.js
-rw-r--r--    1 root    root                     2396 pro 28 01:57
/usr/lib/node_modules/fstream/lib/file-writer.js
-rw-r--r--    1 root    root                      632 pro 28 01:57
/usr/lib/node_modules/fstream/lib/get-type.js
-rw-r--r--    1 root    root                     1542 pro 28 01:57
/usr/lib/node_modules/fstream/lib/link-reader.js
-rw-r--r--    1 root    root                     2788 pro 28 01:57
/usr/lib/node_modules/fstream/lib/link-writer.js
-rw-r--r--    1 root    root                     1966 pro 28 01:57
/usr/lib/node_modules/fstream/lib/proxy-reader.js
-rw-r--r--    1 root    root                     2409 pro 28 01:57
/usr/lib/node_modules/fstream/lib/proxy-writer.js
-rw-r--r--    1 root    root                     6945 pro 28 01:57
/usr/lib/node_modules/fstream/lib/reader.js
-rw-r--r--    1 root    root                      992 pro 28 01:57
/usr/lib/node_modules/fstream/lib/socket-reader.js
-rw-r--r--    1 root    root                    10674 pro 28 01:57
/usr/lib/node_modules/fstream/lib/writer.js
drwxr-xr-x    2 root    root                        0 led 10 19:41
/usr/lib/node_modules/fstream/node_modules
lrwxrwxrwx    1 root    root                       33 led 10 19:41
/usr/lib/node_modules/fstream/node_modules/graceful-fs ->
/usr/lib/node_modules/graceful-fs
lrwxrwxrwx    1 root    root                       30 led 10 19:41
/usr/lib/node_modules/fstream/node_modules/inherits ->
/usr/lib/node_modules/inherits
lrwxrwxrwx    1 root    root                       28 led 10 19:41
/usr/lib/node_modules/fstream/node_modules/mkdirp ->
/usr/lib/node_modules/mkdirp
lrwxrwxrwx    1 root    root                       28 led 10 19:41
/usr/lib/node_modules/fstream/node_modules/rimraf ->
/usr/lib/node_modules/rimraf
-rw-r--r--    1 root    root                      557 pro 28 01:58
/usr/lib/node_modules/fstream/package.json
drwxr-xr-x    2 root    root                        0 led 10 19:41
/usr/share/doc/nodejs-fstream-0.1.21
-rw-r--r--    1 root    root                     1310 zář 12 02:44
/usr/share/doc/nodejs-fstream-0.1.21/LICENSE
-rw-r--r--    1 root    root                     2345 lis  1  2011
/usr/share/doc/nodejs-fstream-0.1.21/README.md
drwxr-xr-x    2 root    root                        0 led 10 19:41
/usr/share/doc/nodejs-fstream-0.1.21/examples
-rw-r--r--    1 root    root                     3928 bře 27  2012
/usr/share/doc/nodejs-fstream-0.1.21/examples/filter-pipe.js
-rw-r--r--    1 root    root                     3235 bře 20  2012
/usr/share/doc/nodejs-fstream-0.1.21/examples/pipe.js
-rw-r--r--    1 root    root                     1293 lis 29  2011
/usr/share/doc/nodejs-fstream-0.1.21/examples/reader.js
-rw-r--r--    1 root    root                      704 lis 29  2011
/usr/share/doc/nodejs-fstream-0.1.21/examples/symlink-write.js

OK

MUST: Each package must consistently use macros. OK
MUST: The package must contain code, or permissable content. OK
MUST: If a package includes something as %doc, it must not affect the runtime
of the application. OK
MUST: Packages must not own files or directories already owned by other
packages. OK
MUST: All filenames in rpm packages must be valid UTF-8. OK
SHOULD: The reviewer should test that the package builds in mock. OK
SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself. OK

Package NEEDSWORK: Fix the license issue

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PXz6DLLQq4&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]