Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891210 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(tchollingsworth@g | |mail.com) --- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Description and Summary OK. MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. $ rpmlint ../SRPMS/nodejs-nopt-2.0.0-2.fc18.src.rpm ../RPMS/noarch/nodejs-nopt-2.0.0-2.fc18.noarch.rpm nodejs-nopt.src: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-nopt.src: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-nopt.src: W: spelling-error %description -l en_US npm -> pm, rpm, ppm nodejs-nopt.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-nopt.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-nopt.noarch: W: spelling-error %description -l en_US npm -> pm, rpm, ppm nodejs-nopt.noarch: W: only-non-binary-in-usr-lib nodejs-nopt.noarch: W: dangling-relative-symlink /usr/bin/nopt ../node_modules/nopt/bin/nopt.js nodejs-nopt.noarch: W: dangling-symlink /usr/lib/node_modules/nopt/node_modules/abbrev /usr/lib/node_modules/abbrev nodejs-nopt.noarch: W: no-manual-page-for-binary nopt 2 packages and 0 specfiles checked; 0 errors, 10 warnings. FIX: The symlink goes to /usr/node_modules/nopt/bin/nopt.js, should go to /usr/lib/node_modules/nopt/bin/nopt.js TODO: If you think it is helpful, work with upstream to add the manpage All others are false positive. MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK MUST: The package must meet the Packaging Guidelines. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. Checked in LICENSE, MIT. OK MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK MUST: The spec file must be written in American English. OK MUST: The spec file for the package MUST be legible. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. $ sha256sum ../SOURCES/nopt-2.0.0.tgz 112e9bea8b745a2e5a59d239e6f6f02e720e080ab8cdca89b6b8f0143ae718b5 ../SOURCES/nopt-2.0.0.tgz $ spectool -g nodejs-nopt.spec Getting http://registry.npmjs.org/nopt/-/nopt-2.0.0.tgz to ./nopt-2.0.0.tgz $ sha256sum nopt-2.0.0.tgz 112e9bea8b745a2e5a59d239e6f6f02e720e080ab8cdca89b6b8f0143ae718b5 nopt-2.0.0.tgz OK MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. OK, builds in mock MUST: Packages must NOT bundle copies of system libraries. OK MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. OK MUST: A Fedora package must not list a file more than once in the spec file's %files listings. OK MUST: Permissions on files must be set properly. $ rpm -q -lv -p ../RPMS/noarch/nodejs-nopt-2.0.0-2.fc18.noarch.rpm lrwxrwxrwx 1 root root 32 led 10 19:01 /usr/bin/nopt -> ../node_modules/nopt/bin/nopt.js drwxr-xr-x 2 root root 0 led 10 19:01 /usr/lib/node_modules/nopt drwxr-xr-x 2 root root 0 led 10 19:01 /usr/lib/node_modules/nopt/bin -rwxr-xr-x 1 root root 1277 čec 6 2011 /usr/lib/node_modules/nopt/bin/nopt.js drwxr-xr-x 2 root root 0 led 10 19:01 /usr/lib/node_modules/nopt/lib -rw-r--r-- 1 root root 15520 čec 24 00:34 /usr/lib/node_modules/nopt/lib/nopt.js drwxr-xr-x 2 root root 0 led 10 19:01 /usr/lib/node_modules/nopt/node_modules lrwxrwxrwx 1 root root 28 led 10 19:01 /usr/lib/node_modules/nopt/node_modules/abbrev -> /usr/lib/node_modules/abbrev -rw-r--r-- 1 root root 499 čec 24 00:36 /usr/lib/node_modules/nopt/package.json drwxr-xr-x 2 root root 0 led 10 19:01 /usr/share/doc/nodejs-nopt-2.0.0 -rw-r--r-- 1 root root 1092 kvě 13 2011 /usr/share/doc/nodejs-nopt-2.0.0/LICENSE -rw-r--r-- 1 root root 7610 říj 14 2011 /usr/share/doc/nodejs-nopt-2.0.0/README.md drwxr-xr-x 2 root root 0 led 10 19:01 /usr/share/doc/nodejs-nopt-2.0.0/examples -rwxr-xr-x 1 root root 1032 bře 31 2011 /usr/share/doc/nodejs-nopt-2.0.0/examples/my-program.js OK MUST: Each package must consistently use macros. OK MUST: The package must contain code, or permissable content. OK MUST: If a package includes something as %doc, it must not affect the runtime of the application. OK MUST: Packages must not own files or directories already owned by other packages. OK MUST: All filenames in rpm packages must be valid UTF-8. OK SHOULD: The reviewer should test that the package builds in mock. OK SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. OK SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense. As mentioned above. NEEDSWORK: Basically, correct the symlink. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L30d2rikUt&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review