Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875150 --- Comment #21 from Honza Horak <hhorak@xxxxxxxxxx> --- Created attachment 676314 --> https://bugzilla.redhat.com/attachment.cgi?id=676314&action=edit Changes made in spec file (In reply to comment #13) > [!]: License field in the package spec file matches the actual license. > Looking at the README and the result of fedora-review's licensecheck > (will attach) it seems there could be also LGPLv2 and/or BSD licensed files. > Could you check it ? Some of the files indeed are under LGPLv2, respectively BSD license. I've included also corresponding license files, but I'm not sure what to do with two identical license files (COPYING.Percona and COPYING.Google) -- both BSD license, but with different copyright authority. I've included both, but I'm not sure if this is a correct solution. If anybody knows better how to handle it, just let me know. (In reply to comment #15) > 2) Given that mariadb won't be available for F17 you don't need to check > whether macroized systemd scriptlets exist (they do in F18+) > > - %if 0%{?systemd_post:1} > - %systemd_post mysqld.service > - %else > - if [ $1 = 1 ]; then > - # Initial installation > - /bin/systemctl daemon-reload >/dev/null 2>&1 || : > - fi > - %endif > + %systemd_post mysqld.service Even if mariadb won't be officially in F17-, some users may want to build it there on their own, so I'd better keep the backward compatible macro there for the time F17 is supported. I've added a comment about the reason into the spec. The rest issues should be fixed, I'm attaching a diff for easier check. Also the links are updated: Spec URL: http://hhorak.fedorapeople.org/mariadb-review/mariadb.spec SRPM URL: http://hhorak.fedorapeople.org/mariadb-review/mariadb-5.5.28a-5.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=q0ZpOrH932&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review