[Bug 846488] Review Request: babeltrace - Trace Viewer and Converter, mainly for the Common Trace Format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=846488

--- Comment #8 from Brendan Jones <brendan.jones.it@xxxxxxxxx> ---
A few things. You have the same file being owned my multiple packages.

You only need to include the license file once if a package that it is provided
by a parent package.

Use %doc in the main package and then remove them from the sub-packages. As
long as the license files are present for every possibly combination of
installed packages.

/usr/share/doc/babeltrace/ChangeLog
/usr/share/doc/babeltrace/gpl-2.0.txt
/usr/share/doc/babeltrace/mit-license.txt
/usr/share/doc/babeltrace/std-ext-lib.txt
/usr/share/doc/babeltrace/LICENSE

would become 

%doc LICENSE gpl-2.0.txt mit-license.txt ChangeLog

in only the main babeltrace and libbabeltrace packages.

You could then drop the /usr/share/doc/babeltrace directory altogether.

You should also run the binary generated under tests in the %check section

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wB3SMElQc7&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]