Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875150 Tom Lane <tgl@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(tgl@xxxxxxxxxx) | --- Comment #17 from Tom Lane <tgl@xxxxxxxxxx> --- (In reply to comment #16) > Tom, do you remember if there is a reason to run the tests in %build section? The reason I've historically run mysql's regression tests (and also postgresql's) in the %build part is that %check is misdesigned: it runs the checks only after the %install section, so that a lot of work is wasted if the regression test fails. I might be willing to tolerate that and use %check if it actually did anything useful, like say if rpmbuild had an option to control whether to run the %check part or not. Since it doesn't, and we have to roll our own support for that anyhow (cf %runselftest in these specfiles), I find %check to be completely useless and best ignored. YMMV of course. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lEycLYR3K3&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review