Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875150 --- Comment #15 from Jiri Popelka <jpopelka@xxxxxxxxxx> --- Some suggestions for spec file clean-up: 1) - %post libs - /sbin/ldconfig + %post libs -p /sbin/ldconfig - %postun libs - if [ $1 = 0 ] ; then - /sbin/ldconfig - fi + %postun libs -p /sbin/ldconfig and there's no need to 'Requires: /sbin/ldconfig' in '%package libs' 2) Given that mariadb won't be available for F17 you don't need to check whether macroized systemd scriptlets exist (they do in F18+) - %if 0%{?systemd_post:1} - %systemd_post mysqld.service - %else - if [ $1 = 1 ]; then - # Initial installation - /bin/systemctl daemon-reload >/dev/null 2>&1 || : - fi - %endif + %systemd_post mysqld.service 3) could this be removed (there's been rpm 4.10 in F18) ? # When rpm 4.9 is universal, this could be cleaned up: %global __perl_requires %{SOURCE999} %global __perllib_requires %{SOURCE999} -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CH0Aj4sAkc&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review