Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891235 --- Comment #1 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Summary OK. Description OK. MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. $ rpmlint ../SRPMS/nodejs-semver-1.1.1-1.fc18.src.rpm ../RPMS/noarch/nodejs-semver-1.1.1-1.fc18.noarch.rpm nodejs-semver.src: W: spelling-error Summary(en_US) versioner -> version er, version-er, version nodejs-semver.src: W: spelling-error Summary(en_US) npm -> pm, rpm, ppm nodejs-semver.src: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-semver.src: W: spelling-error %description -l en_US npm -> pm, rpm, ppm nodejs-semver.src: W: strange-permission nodejs-semver.spec 0600L nodejs-semver.src: W: no-%build-section nodejs-semver.noarch: W: spelling-error Summary(en_US) versioner -> version er, version-er, version nodejs-semver.noarch: W: spelling-error Summary(en_US) npm -> pm, rpm, ppm nodejs-semver.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-semver.noarch: W: spelling-error %description -l en_US npm -> pm, rpm, ppm nodejs-semver.noarch: W: only-non-binary-in-usr-lib nodejs-semver.noarch: W: no-manual-page-for-binary semver 2 packages and 0 specfiles checked; 0 errors, 12 warnings. TODO: Fix the permissions on the spec (should be rw-rw-r--) FIX: Add %build section (even if empty), it is needed TODO: Consider contacting upstream about the manpage, if you think it would be helpful All other things are false positive. MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK MUST: The package must meet the Packaging Guidelines. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. Checked in LICENSE, MIT. OK MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK MUST: The spec file must be written in American English. OK MUST: The spec file for the package MUST be legible. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. $ sha256sum ../SOURCES/semver-1.1.1.tgz d76d0f0c91e1a5ad6ea1eb8830073510c6a6e5d0d275ba2a686425ee770f8c26 ../SOURCES/semver-1.1.1.tgz $ wget -q http://registry.npmjs.org/semver/-/semver-1.1.1.tgz $ sha256sum semver-1.1.1.tgz d76d0f0c91e1a5ad6ea1eb8830073510c6a6e5d0d275ba2a686425ee770f8c26 semver-1.1.1.tg MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK, builds in mock MUST: Packages must NOT bundle copies of system libraries. OK MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [13] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations). OK MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. $ rpm -q -lv -p ../RPMS/noarch/nodejs-semver-1.1.1-1.fc18.noarch.rpm lrwxrwxrwx 1 root root 37 led 8 14:37 /usr/bin/semver -> ../lib/node_modules/semver/bin/semver drwxr-xr-x 2 root root 0 led 8 14:37 /usr/lib/node_modules/semver drwxr-xr-x 2 root root 0 led 8 14:37 /usr/lib/node_modules/semver/bin -rwxr-xr-x 1 root root 1944 lis 29 01:46 /usr/lib/node_modules/semver/bin/semver drwxr-xr-x 2 root root 0 led 8 14:37 /usr/lib/node_modules/semver/node_modules -rw-r--r-- 1 root root 436 lis 29 01:46 /usr/lib/node_modules/semver/package.json -rw-r--r-- 1 root root 9196 říj 2 19:02 /usr/lib/node_modules/semver/semver.js drwxr-xr-x 2 root root 0 led 8 14:37 /usr/share/doc/nodejs-semver-1.1.1 -rw-r--r-- 1 root root 1092 kvě 13 2011 /usr/share/doc/nodejs-semver-1.1.1/LICENSE -rw-r--r-- 1 root root 3979 říj 18 12:37 /usr/share/doc/nodejs-semver-1.1.1/README.md OK MUST: Each package must consistently use macros. OK MUST: The package must contain code, or permissable content. OK MUST: If a package includes something as %doc, it must not affect the runtime of the application. OK MUST: Packages must not own files or directories already owned by other packages. OK MUST: All filenames in rpm packages must be valid UTF-8. OK SHOULD: The reviewer should test that the package builds in mock. OK SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. OK SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense. Already mentioned above Please fix the FIX items and consider fixing TODOs. Resolution: NEEDSWORK. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jMhnAk2gkM&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review