Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891223 T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(tchollingsworth@g | |mail.com) | --- Comment #2 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> --- Thanks for reviewing this! (In reply to comment #1) > Summary verified from package.json > > TODO: Description should rather be at least a sentence. Something like: > > "A method for reading user input from stdin in node.js. > Similar to the readline builtin's question() method, > but with a few more features." Fixed. > MUST: rpmlint must be run on the source rpm and all binary rpms the build > produces. The output should be posted in the review. > > nodejs-read.src: W: summary-not-capitalized C read(1) for node programs > nodejs-read.src: W: no-%build-section > nodejs-read.noarch: W: summary-not-capitalized C read(1) for node programs Fixed. > nodejs-read.noarch: W: only-non-binary-in-usr-lib Node modules are installed in /usr/lib consistent with both upstream and other interpreted languages in the distribution like Python. > nodejs-read.noarch: W: dangling-symlink > /usr/lib/node_modules/read/node_modules/mute-stream > /usr/lib/node_modules/mute-stream > 2 packages and 0 specfiles checked; 0 errors, 5 warnings. > > TODO: Consider adding a word (such as Function or Method) at the beginning > of the summary to prevent summary-not-capitalized > FIX: Add %build section (even if empty), it is needed (some tools might want > to add something at the beginning or at the end of it) Fixed. > Symblink OK (package requires npm(mute-stream)) > > Other hints: > > TODO: Consider dropping %defattr(-,root,root,-) in %files, it is not needed. > TODO: Remove the BuildRoot variable, it is not needed either. Per the discussion in bug 891194 I would like to retain EL5 constructions at this time. Spec: http://patches.fedorapeople.org/npm/nodejs-read.spec SRPM: http://patches.fedorapeople.org/npm/nodejs-read-1.0.4-2.fc17.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4847388 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HvC2sCu0dm&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review