Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891207 T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(tchollingsworth@g | |mail.com) | --- Comment #2 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> --- Thanks for taking this review! (In reply to comment #1) > TODO: Consider using a summary that actually tells the user, what it is, > something like: > Basic pass-through stream, but when muted, the bytes are dropped Fixed. > MUST: rpmlint must be run on the source rpm and all binary rpms the build > produces. The output should be posted in the review. > > nodejs-mute-stream.src: W: invalid-url URL: > https://github.com/isaacs/mute-st HTTP Error 404: Not Found > nodejs-mute-stream.src: W: no-%build-section > nodejs-mute-stream.noarch: W: invalid-url URL: > https://github.com/isaacs/mute-st HTTP Error 404: Not Found Fixed. > nodejs-mute-stream.noarch: W: only-non-binary-in-usr-lib Node modules are installed in /usr/lib consistent with upstream and other interpreted languages in the distribution. > 2 packages and 0 specfiles checked; 0 errors, 4 warnings. > > FIX: Correct the URL in the spec (the ned is missing) > FIX: Add %build section (even if empty), it is needed (some tools might want > to add something at the beginning or at the end of it) Fixed. > TODO: Consider dropping %defattr(-,root,root,-) in %files, it is not needed. > TODO: Remove the BuildRoot variable, it is not needed either. I'd like to retain EL5 constructions for the time being, as discussed in bug 891194. Spec: http://patches.fedorapeople.org/npm/nodejs-mute-stream.spec SRPM: http://patches.fedorapeople.org/npm/nodejs-mute-stream-0.0.3-1.fc17.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4847373 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=V3jEVlymBg&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review