Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891221 T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(tchollingsworth@g | |mail.com) | --- Comment #2 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> --- THanks(In reply to comment #1) > FIX: Summary from package.json doesn't seem very useful to me. Replace it > with something more informative, like: "Prompting wizard for building files > from specialized PromZard modules" > > TODO: Remove markdown syntax from Description. Links to other projects are > also unnecessary. > > FIX: You have FIXME in License, but there is BSD in URL. I suppose you > entered it to a bad row. Correct License and URL fileds. Fixed these three. > MUST: rpmlint must be run on the source rpm and all binary rpms the build > produces. The output should be posted in the review. > > nodejs-promzard.src: W: summary-not-capitalized C prompting wizardly Fixed. > nodejs-promzard.src: W: spelling-error %description -l en_US npm -> pm, rpm, > ppm False positive; "npm" is the correct way to refer to the Node.js Package Manager: https://npmjs.org/doc/faq.html#Is-it-npm-or-NPM-or-Npm > nodejs-promzard.src: W: spelling-error %description -l en_US init -> unit, > int, nit False positive; used in a command line example > nodejs-promzard.src: W: spelling-error %description -l en_US > reimplementation -> re implementation, re-implementation, implementation False positive, valid spelling: http://en.wiktionary.org/wiki/reimplementation > nodejs-promzard.src: W: spelling-error %description -l en_US schemas -> > schema, sachems, schemes False positive, valid spelling: http://en.wiktionary.org/wiki/schemas > nodejs-promzard.src: W: invalid-license FIXME > nodejs-promzard.src: W: invalid-url URL BSD > nodejs-promzard.src: W: no-%build-section Fixed. <snip repeats> > nodejs-promzard.noarch: W: only-non-binary-in-usr-lib Node.js installs modules in /usr/lib, consistent with upstream and other interpreted languages in the distribution. > 2 packages and 0 specfiles checked; 0 errors, 16 warnings. > > FIX: Add %build section (even if empty), it is needed (some tools might want > to add something at the beginning or at the end of it) Fixed. > > I suppose npm-init in example folder is just some simplified example > version, right? Correct. > TODO: Consider dropping %defattr(-,root,root,-) in %files, it is not needed. > TODO: Remove the BuildRoot variable, it is not needed either. Per the discussion in bug 891194 I'd like to retain EL5 constructions at this time. Spec: http://patches.fedorapeople.org/npm/nodejs-promzard.spec SRPM: http://patches.fedorapeople.org/npm/nodejs-promzard-0.2.0-2.fc17.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4847361 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=J0jEOU3PE4&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review