Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891223 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(tchollingsworth@g | |mail.com) --- Comment #1 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Summary verified from package.json TODO: Description should rather be at least a sentence. Something like: "A method for reading user input from stdin in node.js. Similar to the readline builtin's question() method, but with a few more features." MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. nodejs-read.src: W: summary-not-capitalized C read(1) for node programs nodejs-read.src: W: no-%build-section nodejs-read.noarch: W: summary-not-capitalized C read(1) for node programs nodejs-read.noarch: W: only-non-binary-in-usr-lib nodejs-read.noarch: W: dangling-symlink /usr/lib/node_modules/read/node_modules/mute-stream /usr/lib/node_modules/mute-stream 2 packages and 0 specfiles checked; 0 errors, 5 warnings. TODO: Consider adding a word (such as Function or Method) at the beginning of the summary to prevent summary-not-capitalized FIX: Add %build section (even if empty), it is needed (some tools might want to add something at the beginning or at the end of it) Symblink OK (package requires npm(mute-stream)) MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK MUST: The package must meet the Packaging Guidelines. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. License chcecked in LICENSE file: BSD. OK MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK MUST: The spec file must be written in American English. OK MUST: The spec file for the package MUST be legible. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. $ sha256sum ../SOURCES/read-1.0.4.tgz 8be269afeaa7cc62feb4672e8e61e5133152266dc5347b23cf5b05bc40789601 ../SOURCES/read-1.0.4.tgz $ wget -q http://registry.npmjs.org/read/-/read-1.0.4.tgz $ sha256sum read-1.0.4.tgz 8be269afeaa7cc62feb4672e8e61e5133152266dc5347b23cf5b05bc40789601 read-1.0.4.tgz OK MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK, builds in mock MUST: Packages must NOT bundle copies of system libraries. OK MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. OK MUST: A Fedora package must not list a file more than once in the spec file's %files listings. OK MUST: Permissions on files must be set properly. $ rpm -q -lv -p ../RPMS/noarch/nodejs-read-1.0.4-1.fc18.noarch.rpm drwxr-xr-x 2 root root 0 led 7 20:05 /usr/lib/node_modules/read drwxr-xr-x 2 root root 0 led 7 20:05 /usr/lib/node_modules/read/lib -rw-r--r-- 1 root root 2414 srp 17 02:22 /usr/lib/node_modules/read/lib/read.js drwxr-xr-x 2 root root 0 led 7 20:05 /usr/lib/node_modules/read/node_modules lrwxrwxrwx 1 root root 33 led 7 20:05 /usr/lib/node_modules/read/node_modules/mute-stream -> /usr/lib/node_modules/mute-stream -rw-r--r-- 1 root root 473 srp 17 02:26 /usr/lib/node_modules/read/package.json drwxr-xr-x 2 root root 0 led 7 20:05 /usr/share/doc/nodejs-read-1.0.4 -rw-r--r-- 1 root root 1318 bře 17 2012 /usr/share/doc/nodejs-read-1.0.4/LICENCE -rw-r--r-- 1 root root 1721 srp 17 02:26 /usr/share/doc/nodejs-read-1.0.4/README.md drwxr-xr-x 2 root root 0 led 7 20:05 /usr/share/doc/nodejs-read-1.0.4/example -rw-r--r-- 1 root root 520 čec 24 09:44 /usr/share/doc/nodejs-read-1.0.4/example/example.js MUST: Each package must consistently use macros. OK MUST: The package must contain code, or permissable content. OK MUST: If a package includes something as %doc, it must not affect the runtime of the application. OK MUST: Packages must not own files or directories already owned by other packages. OK MUST: All filenames in rpm packages must be valid UTF-8. OK SHOULD: The reviewer should test that the package builds in mock. OK SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. OK Other hints: TODO: Consider dropping %defattr(-,root,root,-) in %files, it is not needed. TODO: Remove the BuildRoot variable, it is not needed either. Please fix the FIX items and consider fixing TODOs. Resolution: NEEDSWORK. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vzV1UZL7ER&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review