Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891207 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(tchollingsworth@g | |mail.com) --- Comment #1 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Description verified from README.md Summary verified from README.md TODO: Consider using a summary that actually tells the user, what it is, something like: Basic pass-through stream, but when muted, the bytes are dropped MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. nodejs-mute-stream.src: W: invalid-url URL: https://github.com/isaacs/mute-st HTTP Error 404: Not Found nodejs-mute-stream.src: W: no-%build-section nodejs-mute-stream.noarch: W: invalid-url URL: https://github.com/isaacs/mute-st HTTP Error 404: Not Found nodejs-mute-stream.noarch: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 0 errors, 4 warnings. FIX: Correct the URL in the spec (the ned is missing) FIX: Add %build section (even if empty), it is needed (some tools might want to add something at the beginning or at the end of it) MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK MUST: The package must meet the Packaging Guidelines. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. License chcecked in LICENSE file: BSD. OK MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK MUST: The spec file must be written in American English. OK MUST: The spec file for the package MUST be legible. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. $ sha256sum ../SOURCES/mute-stream-0.0.3.tgz 7bb2401ad9afaa6f04bc1d2d9411a6e41d7a6198de929d4522e95eeae78b1082 ../SOURCES/mute-stream-0.0.3.tgz $ wget http://registry.npmjs.org/mute-stream/-/mute-stream-0.0.3.tgz $ sha256sum mute-stream-0.0.3.tgz 7bb2401ad9afaa6f04bc1d2d9411a6e41d7a6198de929d4522e95eeae78b1082 mute-stream-0.0.3.tgz OK MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK, builds in mock MUST: Packages must NOT bundle copies of system libraries. OK MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. OK MUST: A Fedora package must not list a file more than once in the spec file's %files listings. OK MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. $ rpm -q -lv -p ../RPMS/noarch/nodejs-mute-stream-0.0.3-1.fc18.noarch.rpm drwxr-xr-x 2 root root 0 led 7 19:19 /usr/lib/node_modules/mute-stream -rw-r--r-- 1 root root 2787 srp 15 07:15 /usr/lib/node_modules/mute-stream/mute.js -rw-r--r-- 1 root root 517 srp 15 07:16 /usr/lib/node_modules/mute-stream/package.json drwxr-xr-x 2 root root 0 led 7 19:19 /usr/share/doc/nodejs-mute-stream-0.0.3 -rw-r--r-- 1 root root 1310 čec 24 03:16 /usr/share/doc/nodejs-mute-stream-0.0.3/LICENSE -rw-r--r-- 1 root root 1338 čec 25 00:19 /usr/share/doc/nodejs-mute-stream-0.0.3/README.md OK MUST: Each package must consistently use macros. OK MUST: The package must contain code, or permissable content. OK MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. OK MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. OK MUST: All filenames in rpm packages must be valid UTF-8. OK SHOULD: The reviewer should test that the package builds in mock. OK SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. OK Other hints: TODO: Consider dropping %defattr(-,root,root,-) in %files, it is not needed. TODO: Remove the BuildRoot variable, it is not needed either. Please fix the FIX items and consider fixing TODOs. Resolution: NEEDSWORK. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wv1pouqCJa&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review