[Bug 891461] Review Request: phantomjs - Headless WebKit with a JavaScript API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891461

Michael Scherer <misc@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misc@xxxxxxxx

--- Comment #1 from Michael Scherer <misc@xxxxxxxx> ---
There is a few bundled libraries ( besides the one that you already removed,
bundling qt is just insane ) :

- linenoise ( likely modified )

- coffeescript

There is the directory ghostdriver, that bundle and modify code from
https://github.com/detro/ghostdriver

there is a copy of  qcommandline too.


And given the mess that the tarball is from a license points of view, I think
it may be easier for us to clean it. 
Pro :
- smaller tarball ( smaller srpm )
- less noise if someone decide to use coverty or anything on the code
- easier to review from a license and bundling point of view
Cons :
- more work for you as you need to write a cleaning script and use it

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gmu9EDq6Ns&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]