Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891206 Michael Scherer <misc@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@xxxxxxxx Flags| |fedora-review? --- Comment #1 from Michael Scherer <misc@xxxxxxxx> --- A few notes : 1) %defattr(-,root,root,-) BuildRoot, and cleaning of root before %install and %clean are not needed, can you remove them ? 2) %check is not used 3) could the summary be improved a little ? Otherwise the package seems good and buildable, so let's start the formal review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OvyzaqLuqB&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review