Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891739 Kevin Fenzi <kevin@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #2 from Kevin Fenzi <kevin@xxxxxxxxx> --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License GPLv2+ See below - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: cc55fca4863298278a12e55382cdebaa8475e76c43b04e701ef7608831e1cb2f v1.0.5.tar.gz cc55fca4863298278a12e55382cdebaa8475e76c43b04e701ef7608831e1cb2f v1.0.5.tar.gz.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. From the headers in the source files, the license here should be GPLv2+ ? 2. Include the LICENSE file as a %doc? 3. rpmlint says: trac-CGit-plugin.noarch: W: spelling-error %description -l en_US url -> URL, curl, purl trac-CGit-plugin.noarch: W: spelling-error %description -l en_US ini -> uni, in, ii trac-CGit-plugin.noarch: W: no-documentation trac-CGit-plugin.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/cgit/web_ui.py 0644L /usr/bin/env You could drop the /usr/bin/env line? trac-CGit-plugin.src: W: spelling-error %description -l en_US url -> URL, curl, purl trac-CGit-plugin.src: W: spelling-error %description -l en_US ini -> uni, in, ii 2 packages and 0 specfiles checked; 1 errors, 5 warnings. The rest can be ignored. If you can fix those minor things before import, this is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tn9o5MpIcE&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review