Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876399 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec from from SRPM is newer than standalone new. Using SRPM version for this review. URL and Source0 are Ok. Source tar ball is original (SHA-256: bfd420e91c762b395c87e6748bb72f48ebab4a8b8917508034d6c2ba4ece034c). Ok. Summary verified from META.yml. Ok. Description verified from lib/ExtUtils/Typemaps/Default.pm. Ok. License verified from lib/**/.pm. Ok. No XS code, noarch BuildArch is Ok. TODO: Remove deleting empty directories. Modern Module::Build does not leave empty directories. TODO: Do not package META.json, there are no unique useful data. All tests pass. Ok. $ rpmlint perl-ExtUtils-Typemaps-Default.spec ../SRPMS/perl-ExtUtils-Typemaps-Default-1.01-2.fc19.src.rpm ../RPMS/noarch/perl-ExtUtils-Typemaps-Default-1.01-2.fc19.noarch.rpm perl-ExtUtils-Typemaps-Default.src: W: spelling-error %description -l en_US typemap -> type map, type-map, typeface perl-ExtUtils-Typemaps-Default.noarch: W: spelling-error %description -l en_US typemap -> type map, type-map, typeface 2 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-ExtUtils-Typemaps-Default-1.01-2.fc19.noarch.rpm drwxr-xr-x 2 root root 0 Jan 4 16:18 /usr/share/doc/perl-ExtUtils-Typemaps-Default-1.01 -rw-r--r-- 1 root root 710 Oct 6 11:46 /usr/share/doc/perl-ExtUtils-Typemaps-Default-1.01/Changes -rw-r--r-- 1 root root 2490 Oct 6 11:46 /usr/share/doc/perl-ExtUtils-Typemaps-Default-1.01/META.json -rw-r--r-- 1 root root 2054 Jan 4 16:18 /usr/share/man/man3/ExtUtils::Typemap::Basic.3pm.gz -rw-r--r-- 1 root root 2052 Jan 4 16:18 /usr/share/man/man3/ExtUtils::Typemap::Default.3pm.gz -rw-r--r-- 1 root root 2066 Jan 4 16:18 /usr/share/man/man3/ExtUtils::Typemap::ObjectMap.3pm.gz -rw-r--r-- 1 root root 2053 Jan 4 16:18 /usr/share/man/man3/ExtUtils::Typemap::STL.3pm.gz -rw-r--r-- 1 root root 2061 Jan 4 16:18 /usr/share/man/man3/ExtUtils::Typemap::STL::String.3pm.gz -rw-r--r-- 1 root root 2063 Jan 4 16:18 /usr/share/man/man3/ExtUtils::Typemap::STL::Vector.3pm.gz -rw-r--r-- 1 root root 2392 Jan 4 16:18 /usr/share/man/man3/ExtUtils::Typemaps::Basic.3pm.gz -rw-r--r-- 1 root root 2404 Jan 4 16:18 /usr/share/man/man3/ExtUtils::Typemaps::Default.3pm.gz -rw-r--r-- 1 root root 2666 Jan 4 16:18 /usr/share/man/man3/ExtUtils::Typemaps::ObjectMap.3pm.gz -rw-r--r-- 1 root root 2431 Jan 4 16:18 /usr/share/man/man3/ExtUtils::Typemaps::STL.3pm.gz -rw-r--r-- 1 root root 2507 Jan 4 16:18 /usr/share/man/man3/ExtUtils::Typemaps::STL::String.3pm.gz -rw-r--r-- 1 root root 2573 Jan 4 16:18 /usr/share/man/man3/ExtUtils::Typemaps::STL::Vector.3pm.gz drwxr-xr-x 2 root root 0 Jan 4 16:18 /usr/share/perl5/vendor_perl/ExtUtils drwxr-xr-x 2 root root 0 Jan 4 16:18 /usr/share/perl5/vendor_perl/ExtUtils/Typemap -rw-r--r-- 1 root root 778 Jan 4 16:18 /usr/share/perl5/vendor_perl/ExtUtils/Typemap/Basic.pm -rw-r--r-- 1 root root 782 Jan 4 16:18 /usr/share/perl5/vendor_perl/ExtUtils/Typemap/Default.pm -rw-r--r-- 1 root root 814 Jan 4 16:18 /usr/share/perl5/vendor_perl/ExtUtils/Typemap/ObjectMap.pm drwxr-xr-x 2 root root 0 Jan 4 16:18 /usr/share/perl5/vendor_perl/ExtUtils/Typemap/STL -rw-r--r-- 1 root root 762 Jan 4 16:18 /usr/share/perl5/vendor_perl/ExtUtils/Typemap/STL.pm -rw-r--r-- 1 root root 824 Jan 4 16:18 /usr/share/perl5/vendor_perl/ExtUtils/Typemap/STL/String.pm -rw-r--r-- 1 root root 824 Jan 4 16:18 /usr/share/perl5/vendor_perl/ExtUtils/Typemap/STL/Vector.pm drwxr-xr-x 2 root root 0 Jan 4 16:18 /usr/share/perl5/vendor_perl/ExtUtils/Typemaps -rw-r--r-- 1 root root 2088 Jan 4 16:18 /usr/share/perl5/vendor_perl/ExtUtils/Typemaps/Basic.pm -rw-r--r-- 1 root root 1925 Jan 4 16:18 /usr/share/perl5/vendor_perl/ExtUtils/Typemaps/Default.pm -rw-r--r-- 1 root root 4994 Jan 4 16:18 /usr/share/perl5/vendor_perl/ExtUtils/Typemaps/ObjectMap.pm drwxr-xr-x 2 root root 0 Jan 4 16:18 /usr/share/perl5/vendor_perl/ExtUtils/Typemaps/STL -rw-r--r-- 1 root root 1840 Jan 4 16:18 /usr/share/perl5/vendor_perl/ExtUtils/Typemaps/STL.pm -rw-r--r-- 1 root root 2294 Jan 4 16:18 /usr/share/perl5/vendor_perl/ExtUtils/Typemaps/STL/String.pm -rw-r--r-- 1 root root 8800 Jan 4 16:18 /usr/share/perl5/vendor_perl/ExtUtils/Typemaps/STL/Vector.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-ExtUtils-Typemaps-Default-1.01-2.fc19.noarch.rpm | sort |uniq -c 1 perl(ExtUtils::Typemaps) 1 perl(ExtUtils::Typemaps) >= 1.00 1 perl(ExtUtils::Typemaps::Basic) 1 perl(ExtUtils::Typemaps::Default) 1 perl(ExtUtils::Typemaps::ObjectMap) 1 perl(ExtUtils::Typemaps::STL) 1 perl(ExtUtils::Typemaps::STL::String) 1 perl(ExtUtils::Typemaps::STL::Vector) 1 perl(:MODULE_COMPAT_5.16.2) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. TODO: Filter under-specified (unversiones) `perl(ExtUtils::Typemaps)' from run-time dependencies. $ rpm -q --provides -p ../RPMS/noarch/perl-ExtUtils-Typemaps-Default-1.01-2.fc19.noarch.rpm | sort |uniq -c 1 perl(ExtUtils::Typemap::Basic) = 1.01 1 perl(ExtUtils::Typemap::Default) = 1.01 1 perl(ExtUtils::Typemap::ObjectMap) = 1.01 1 perl(ExtUtils::Typemaps::Basic) = 1.01 1 perl(ExtUtils::Typemaps::Default) = 1.01 1 perl-ExtUtils-Typemaps-Default = 1.01-2.fc19 1 perl(ExtUtils::Typemaps::ObjectMap) = 1.01 1 perl(ExtUtils::Typemaps::STL) = 1.01 1 perl(ExtUtils::Typemaps::STL::String) = 1.01 1 perl(ExtUtils::Typemaps::STL::Vector) = 1.01 1 perl(ExtUtils::Typemap::STL) = 1.01 1 perl(ExtUtils::Typemap::STL::String) = 1.01 1 perl(ExtUtils::Typemap::STL::Vector) = 1.01 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-ExtUtils-Typemaps-Default-1.01-2.fc19.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4840105). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider fixing `TODO' items before building the package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=o0ZJ1nPaHJ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review