Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887611 --- Comment #8 from Alec Leamas <leamas.alec@xxxxxxxxx> --- (In reply to comment #7) > Thanks for your feedback, which is reflected in an updated version: > > Spec URL: http://fedorapeople.org/~bubeck/vdr-vnsiserver.spec > SRPM URL: > http://fedorapeople.org/~bubeck/vdr-vnsiserver-0.9.0-0.2. > 20130104git04258ed894.fc17.src.rpm > > (In reply to comment #6) > > Some other drive-by comments: > > - As Mathias says, it's better to offer to trade reviews than to just ask > > for one. > > What do you mean? Should I offer to review someone elses packages if he > reviews mine? Am I allowed to review other peoples packages? Since you ask, and since I cannot find you in the packagers group: it looks like you not are sponsored. If so, you need to add FE_NEEDSPONSOR to the list of Blocks: bugs above, see http://fedoraproject.org/wiki/Package_Review_Process. If so, it also means that you cannot trade reviews and that this package must be reviewed by someone who can sponsor you. Unfortunately, I'm no such person. > I am only packaging the vdr-vnsiserver. The git repository holds many more > plugins and addons and the DLL and binary files from comment #2. After > getting the feedback I only package a subfolder of the git repository > because I did not need the others at all. Therefore, they are not part of > the Source0 anymore. For a description on how to prepare the Source0, see > the comments in the specfile. Which is perfectly fine, but deserved an explanation :) Perhaps it would have been easier to use the complete tarball and remove everything besides the subdir used in %prep, but it's more a question of personal preferences IMHO. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FUXt0l27wB&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review