Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=848144 --- Comment #8 from Michael Schwendt <mschwendt@xxxxxxxxx> --- Created attachment 672205 --> https://bugzilla.redhat.com/attachment.cgi?id=672205&action=edit spec cleanup * The linked spec file is an older one. The src.rpm is much newer. * As I've noticed lots of "no" results for the various checks during the configure step, I skimmed over the spec file and fixed several minor issues. The diff should be self-explaining. * SDL2-devel.x86_64 will conflict with SDL2-devel.i686 due to the sdl2-config script * .pc file: $ pkg-config sdl2 --libs -Wl,-rpath,/usr/lib64 -lSDL2 -lpthread It includes duplicated -lpthread options and another -lSDL2 in the .private section: $ grep pth /usr/lib64/pkgconfig/sdl2.pc Libs: -L${libdir} -Wl,-rpath,${libdir} -lSDL2 -lpthread Libs.private: -lSDL2 -lpthread -lm -ldl -lpthread * Several build requirements seem to be missing. The test programs in the "test" subdirectory fail to build due to that. * If this SDL2 is rebuilt with added BuildRequires, the tests can be built, too. The resulting binary rpm is missing shared library dependencies. Oh, the libs are loaded dynamically by SDL - run-time RPM dependencies will be needed for them, too, however, probably not limited to these: $ grep DYNA config.status D["SDL_AUDIO_DRIVER_ALSA_DYNAMIC"]=" \"libasound.so.2\"" D["SDL_AUDIO_DRIVER_PULSEAUDIO_DYNAMIC"]=" \"libpulse-simple.so.0\"" D["SDL_VIDEO_DRIVER_X11_DYNAMIC"]=" \"libX11.so.6\"" D["SDL_VIDEO_DRIVER_X11_DYNAMIC_XEXT"]=" \"libXext.so.6\"" D["SDL_VIDEO_DRIVER_X11_DYNAMIC_XCURSOR"]=" \"libXcursor.so.1\"" D["SDL_VIDEO_DRIVER_X11_DYNAMIC_XINERAMA"]=" \"libXinerama.so.1\"" D["SDL_VIDEO_DRIVER_X11_DYNAMIC_XINPUT2"]=" \"libXi.so.6\"" D["SDL_VIDEO_DRIVER_X11_DYNAMIC_XRANDR"]=" \"libXrandr.so.2\"" D["SDL_VIDEO_DRIVER_X11_DYNAMIC_XVIDMODE"]=" \"libXxf86vm.so.1\"" -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MkDpI0aQOZ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review