Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868529 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- perl-ZMQ-LibZMQ2.spec.old 2012-11-01 13:17:28.000000000 +0100 +++ perl-ZMQ-LibZMQ2.spec 2012-12-28 01:28:47.000000000 +0100 @@ -1,6 +1,6 @@ Name: perl-ZMQ-LibZMQ2 Version: 1.03 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Perl wrapper for the libzmq 2.x library License: GPL+ or Artistic @@ -11,19 +11,19 @@ BuildRequires: perl(AnyEvent) BuildRequires: perl(Carp) BuildRequires: perl(Cwd) -BuildRequires: perl(Devel::CheckLib) >= 0.4 BuildRequires: perl(ExtUtils::MakeMaker) -BuildRequires: perl(Task::Weaken) +BuildRequires: perl(File::Spec) BuildRequires: perl(Test::Fatal) BuildRequires: perl(Test::More) >= 0.98 BuildRequires: perl(Test::Requires) +BuildRequires: perl(Test::SharedFork) BuildRequires: perl(Test::TCP) >= 1.08 BuildRequires: perl(ZMQ::Constants) >= 1.00 BuildRequires: zeromq-devel -Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) -Requires: perl(Task::Weaken) -Requires: perl(ZMQ::Constants) >= 1.00 +Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) + +%{?perl_default_filter} %description The ZMQ::LibZMQ2 module is a wrapper of the 0MQ message passing library for @@ -35,7 +35,7 @@ %setup -q -n ZMQ-LibZMQ2-%{version} %build -%{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS" +perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS" make %{?_smp_mflags} %install @@ -43,7 +43,6 @@ find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \; find $RPM_BUILD_ROOT -type f -name '*.bs' -size 0 -exec rm -f {} \; -find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \; %{_fixperms} $RPM_BUILD_ROOT/* @@ -59,6 +58,9 @@ %changelog +* Thu Dec 27 2012 Jose Pedro Oliveira <jpo at di.uminho.pt> - 1.03-2 +- Handle review itens (#868529) + * Wed Oct 17 2012 Jose Pedro Oliveira <jpo at di.uminho.pt> - 1.03-1 - First Fedora release. > TODO: You can replace %{__perl} macros with plain perl. Ok. > TODO: Remove deleting empty directories in %install section. Current build system does not leave empty directories. -find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \; Ok. > FIX: Remove bundled inc/* modules or specify all needed dependencies. E.g. Makefile.PL calls use_xshelper from inc/Module/Install/XSUtil.pm that calls use_ppport() which uses Devel::PPPort. This is provided by perl now. Ok. > TODO: Build-require `perl(base)' (lib/ZMQ/LibZMQ2.pm:3). > TODO: Build-require `perl(Exporter)' (lib/ZMQ/LibZMQ2.pm:3). > TODO: Build-require `perl(XSLoader)' (lib/ZMQ/LibZMQ2.pm:4). > TODO: Build-require `perl(constant)' (lib/ZMQ/LibZMQ2.pm:12). Not addressed. Ok. > FIX: Build-require `perl(File::Spec)' (t/100_basic.t:3). +BuildRequires: perl(File::Spec) Ok. > TODO: Build-require `perl(Storable)' (t/100_basic.t:8). Not addressed. Ok. > FIX: Build-require `perl(Test::SharedFork)' (t/104_ipc.t:3). +BuildRequires: perl(Test::SharedFork) Ok. > TODO: Build-require `perl(File::Temp)' (t/104_ipc.t:4). Not addressed. Ok. > FIX: Do not (build-)require `perl(Task::Weaken)', it's not needed anywhere. -BuildRequires: perl(Task::Weaken) -Requires: perl(Task::Weaken) Ok. > FIX: Do not build-require `perl(Devel::CheckLib)' as it is bundled under inc directory, or unbundle the module. -BuildRequires: perl(Devel::CheckLib) >= 0.4 Ok. > FIX: Do not export private library LibZMQ2.so. +%{?perl_default_filter} Ok. > FIX: Do not run-require `perl(Task::Weaken)'. $ rpm -q --requires -p ../RPMS/x86_64/perl-ZMQ-LibZMQ2-1.03-2.fc19.x86_64.rpm | sort | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.14)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libzmq.so.1()(64bit) 1 perl(base) 1 perl(constant) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.16.2) 1 perl(strict) 1 perl(XSLoader) 1 perl(ZMQ::Constants) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Binary requires are Ok. > TODO: Do not require unversioned `perl(ZMQ::Constants)'. Not addressed. Ok. > FIX: Do not export private library LibZMQ2.so. $ rpm -q --provides -p ../RPMS/x86_64/perl-ZMQ-LibZMQ2-1.03-2.fc19.x86_64.rpm | sort | uniq -c 1 perl(ZMQ::LibZMQ2) = 1.03 1 perl-ZMQ-LibZMQ2 = 1.03-2.fc19 1 perl-ZMQ-LibZMQ2(x86-64) = 1.03-2.fc19 Binary provides are Ok. $ rpmlint perl-ZMQ-LibZMQ2.spec ../SRPMS/perl-ZMQ-LibZMQ2-1.03-2.fc19.src.rpm ../RPMS/x86_64/perl-ZMQ-LibZMQ2-1.03-2.fc19.x86_64.rpm perl-ZMQ-LibZMQ2.src: W: spelling-error Summary(en_US) libzmq -> Librium perl-ZMQ-LibZMQ2.x86_64: W: spelling-error Summary(en_US) libzmq -> Librium 2 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint is Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4835928). Ok. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DblWwiZ53Z&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review