Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875352 Nicolas Chauvet (kwizart) <kwizart@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #6 from Nicolas Chauvet (kwizart) <kwizart@xxxxxxxxx> --- I have a little cosmetic annoyance as you seems to prefer tab over space, it looks weird to have a tab for the %doc line instead of one simple space. Also the Group line of the devel is missing one tab. Another concern is about dynamic patching. Specially as if the SONAME is correctly set in the shared object, your patch might become wrong. Besides that I have not other concern, usability was tested by building mfiler4 -------------------------------------- This package (xyzsh) is APPROVED by me -------------------------------------- -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8OWowbkFnO&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review