[Bug 872966] Review Request: spacefm - SpaceFM file manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=872966

Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |mario.blaettermann@xxxxxxxx
                   |                            |m
              Flags|                            |fedora-review?

--- Comment #10 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4833692


$ rpmlint -i -v *
spacefm.src: I: checking
spacefm.src: W: spelling-error %description -l en_US multi -> mulch, mufti
The value of this tag appears to be misspelled. Please double-check.

spacefm.src: W: spelling-error %description -l en_US udev -> dude
The value of this tag appears to be misspelled. Please double-check.

spacefm.src: W: spelling-error %description -l en_US customizable ->
customization
The value of this tag appears to be misspelled. Please double-check.

spacefm.src: I: checking-url http://ignorantguru.github.com/spacefm/ (timeout
10 seconds)
spacefm.src: I: checking-url
http://downloads.sourceforge.net/spacefm/spacefm-0.8.2.tar.xz (timeout 10
seconds)
spacefm.i686: I: checking
spacefm.i686: W: spelling-error %description -l en_US multi -> mulch, mufti
The value of this tag appears to be misspelled. Please double-check.

spacefm.i686: W: spelling-error %description -l en_US udev -> dude
The value of this tag appears to be misspelled. Please double-check.

spacefm.i686: W: spelling-error %description -l en_US customizable ->
customization
The value of this tag appears to be misspelled. Please double-check.

spacefm.i686: W: incoherent-version-in-changelog 0.8-2-4 ['0.8.2-4.fc19',
'0.8.2-4']
The latest entry in %changelog contains a version identifier that is not
coherent with the epoch:version-release tuple of the package.

spacefm.i686: I: checking-url http://ignorantguru.github.com/spacefm/ (timeout
10 seconds)
spacefm.i686: W: no-manual-page-for-binary spacefm-auth
Each executable in standard binary directories should have a man page.

spacefm.i686: W: no-manual-page-for-binary spacefm
Each executable in standard binary directories should have a man page.

spacefm.x86_64: I: checking
spacefm.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti
The value of this tag appears to be misspelled. Please double-check.

spacefm.x86_64: W: spelling-error %description -l en_US udev -> dude
The value of this tag appears to be misspelled. Please double-check.

spacefm.x86_64: W: spelling-error %description -l en_US customizable ->
customization
The value of this tag appears to be misspelled. Please double-check.

spacefm.x86_64: W: incoherent-version-in-changelog 0.8-2-4 ['0.8.2-4.fc19',
'0.8.2-4']
The latest entry in %changelog contains a version identifier that is not
coherent with the epoch:version-release tuple of the package.

spacefm.x86_64: I: checking-url http://ignorantguru.github.com/spacefm/
(timeout 10 seconds)
spacefm.x86_64: W: no-manual-page-for-binary spacefm-auth
Each executable in standard binary directories should have a man page.

spacefm.x86_64: W: no-manual-page-for-binary spacefm
Each executable in standard binary directories should have a man page.

spacefm-debuginfo.i686: I: checking
spacefm-debuginfo.i686: I: checking-url http://ignorantguru.github.com/spacefm/
(timeout 10 seconds)
spacefm-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/spacefm-0.8.2/src/desktop/working-area.c
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

spacefm-debuginfo.x86_64: I: checking
spacefm-debuginfo.x86_64: I: checking-url
http://ignorantguru.github.com/spacefm/ (timeout 10 seconds)
spacefm-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/spacefm-0.8.2/src/desktop/working-area.c
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

spacefm.spec: I: checking-url
http://downloads.sourceforge.net/spacefm/spacefm-0.8.2.tar.xz (timeout 10
seconds)
5 packages and 1 specfiles checked; 2 errors, 15 warnings.




The missing man page is no problem. It is not up to you to create it. But maybe
you should inform the upstream folks. The same for the old FSF address. You
might patch the source files (but not the COPYING files!), this is allowed by
the packaging guidelines. But don't bother with them. Just inform the upstream
developers so that they can fix it in future releases.

"spacefm.i686: W: incoherent-version-in-changelog 0.8-2-4 ['0.8.2-4.fc19',
'0.8.2-4']"
Please fix this, has to be: 0.8.2-4

Source0:    http://downloads.sourceforge.net/spacefm/spacefm-0.8.2.tar.xz
Well, it's your choice to don't use macros for name and version here. But using
macros makes it easier to update the package to a newer upstream version, and
even after a possible name change. Not a review blocker, though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dAlow0Bawf&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]