Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: koji - Build system tools https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229250 ------- Additional Comments From jkeating@xxxxxxxxxx 2007-02-20 16:48 EST ------- (In reply to comment #8) > Well, > > * License > * www/static/js/jsolait/lib/iter.js > - says this is GPL It should be perfectly acceptable to use GPL code within an LGPL package. As stated, all things are LGPL unless otherwise indicated. > * Documentation > * Add "Authors COPYING LGPL" to main package. > Especially, including copyright document is rather > mandatory (however copyright must be clarified) Whoops! I forgot to add those to the package when I added them to the source repo. My bad. > > * Source > * Where is the source? BTW during -6 and -7, source tarball > seem to be silently changed without their version number > unchanged... Currently the source is provided in the srpm. This is the current preferred method of distribution, given that we are the upstream. I haven't versioned the source just yet, I need to work with the other maintainers on how to properly handle that, so yeah, the source changed a little bit. http://people.redhat.com/jkeating/extras/koji/koji-0.9.5-8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review