Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887846 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #6 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- perl-Math-Geometry-Voronoi.spec.old 2012-12-21 10:07:49.763000000 +0100 +++ perl-Math-Geometry-Voronoi.spec 2013-01-02 14:16:51.245000000 +0100 @@ -1,6 +1,6 @@ Name: perl-Math-Geometry-Voronoi Version: 1.3 -Release: 6%{?dist} +Release: 7%{?dist} Summary: Compute Voronoi diagrams from sets of points License: (GPL+ or Artistic) and MIT # Perl module is licensed as Perl, underlaying C code is MIT @@ -9,14 +9,16 @@ Source0: http://www.cpan.org/authors/id/S/SA/SAMTREGAR/Math-Geometry-Voronoi-%{version}.tar.gz Source1: Math-Geometry-Voronoi-license-mail1.txt Source2: Math-Geometry-Voronoi-license-mail2.txt -BuildRequires: perl(Class::Accessor) +BuildRequires: perl(base) +BuildRequires: perl(Class::Accessor::Fast) BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl(List::Util) BuildRequires: perl(Params::Validate) BuildRequires: perl(Scalar::Util) BuildRequires: perl(Test::More) BuildRequires: perl(XSLoader) -Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) +BuildRequires: dos2unix +Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) %{?perl_default_filter} # Filters (not)shared c libs @@ -27,12 +29,14 @@ %setup -q -n Math-Geometry-Voronoi-%{version} cp -p %{SOURCE1} license-mail1.txt cp -p %{SOURCE2} license-mail2.txt +dos2unix *.c +chmod -x *.c *.h %build -%{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS" +perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS" make %{?_smp_mflags} # Get the license from the e-mail -tail -22 license-mail1.txt | head -20 | base64 -d > C-LICENSE +tail -22 license-mail1.txt | head -20 | base64 -d | dos2unix > C-LICENSE %install make pure_install DESTDIR=%{buildroot} @@ -41,6 +45,7 @@ find %{buildroot} -type f -name '*.bs' -size 0 -exec rm -f {} \; %{_fixperms} %{buildroot}/* +rm -rf %{buildroot}%{perl_vendorarch}/Math/Geometry/leak-test.pl %check make test @@ -52,6 +57,13 @@ %{_mandir}/man3/* %changelog +* Sat Dec 22 2012 Miro Hrončok <miro@xxxxxxxxxx> - 1.3-7 +- Changed %%{__perl} to perl +- Added BR: perl(base) +- Changed BR perl(Class::Accessor) to perl(Class::Accessor::Fast) +- Recoded newlines: C-LICENCE, second mail and *.c +- Removed executable perms from sources and group write perms from e-mails + * Mon Dec 17 2012 Miro Hrončok <miro@xxxxxxxxxx> - 1.3-6 - Removed accidentally added BRs > TODO: You can replace %{__perl} macros with plain perl. Ok. > TODO: Build-require `perl(base)' (lib/Math/Geometry/Voronoi.pm:15). +BuildRequires: perl(base) Ok. > FIX: Build-require `perl(Class::Accessor::Fast)' instead of `perl(Class::Accessor)' (lib/Math/Geometry/Voronoi.pm:15). -BuildRequires: perl(Class::Accessor) +BuildRequires: perl(Class::Accessor::Fast) Ok. > TODO: Recode C-LICENSE file to have UNIX-style end-of-lines. -tail -22 license-mail1.txt | head -20 | base64 -d > C-LICENSE +tail -22 license-mail1.txt | head -20 | base64 -d | dos2unix > C-LICENSE Ok. > TODO: Remove executable permission from source files. +chmod -x *.c *.h Ok. > TODO: Do not package leak-test.pl. The file is useful for upstream developer only and it's installed by EU::MM mistake. +rm -rf %{buildroot}%{perl_vendorarch}/Math/Geometry/leak-test.pl Ok. $ rpmlint perl-Math-Geometry-Voronoi.spec ../SRPMS/perl-Math-Geometry-Voronoi-1.3-7.fc19.src.rpm ../RPMS/x86_64/perl-Math-Geometry-Voronoi-*1.3-7.* 3 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-Math-Geometry-Voronoi-1.3-7.fc19.x86_64.rpm drwxr-xr-x 2 root root 0 Jan 2 14:26 /usr/lib64/perl5/vendor_perl/Math drwxr-xr-x 2 root root 0 Jan 2 14:26 /usr/lib64/perl5/vendor_perl/Math/Geometry -rw-r--r-- 1 root root 12588 Jul 11 2009 /usr/lib64/perl5/vendor_perl/Math/Geometry/Voronoi.pm drwxr-xr-x 2 root root 0 Jan 2 14:26 /usr/lib64/perl5/vendor_perl/auto/Math drwxr-xr-x 2 root root 0 Jan 2 14:26 /usr/lib64/perl5/vendor_perl/auto/Math/Geometry drwxr-xr-x 2 root root 0 Jan 2 14:26 /usr/lib64/perl5/vendor_perl/auto/Math/Geometry/Voronoi -rwxr-xr-x 1 root root 28008 Jan 2 14:26 /usr/lib64/perl5/vendor_perl/auto/Math/Geometry/Voronoi/Voronoi.so drwxr-xr-x 2 root root 0 Jan 2 14:26 /usr/share/doc/perl-Math-Geometry-Voronoi-1.3 -rw-r--r-- 1 root root 1106 Jan 2 14:26 /usr/share/doc/perl-Math-Geometry-Voronoi-1.3/C-LICENSE -rw-r--r-- 1 root root 606 Jul 11 2009 /usr/share/doc/perl-Math-Geometry-Voronoi-1.3/Changes -rw-r--r-- 1 root root 1220 Jul 11 2009 /usr/share/doc/perl-Math-Geometry-Voronoi-1.3/README -rw-r--r-- 1 root root 10939 Jan 2 14:26 /usr/share/doc/perl-Math-Geometry-Voronoi-1.3/license-mail1.txt -rw-r--r-- 1 root root 17000 Jan 2 14:26 /usr/share/doc/perl-Math-Geometry-Voronoi-1.3/license-mail2.txt -rw-r--r-- 1 root root 4417 Jan 2 14:26 /usr/share/man/man3/Math::Geometry::Voronoi.3pm.gz > TODO: Remove write permission for group on license-mail*.txt files. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4832007). Package is good. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GXiMMbJJz6&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review