Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836368 --- Comment #11 from Darryl L. Pierce <dpierce@xxxxxxxxxx> --- (In reply to comment #9) > For 0.0.6-2: > > ! bug dependency > - As this bug depends on 836368, I cannot approve this bug > until bug 836368 is updated. > > * About C extension related things > - This package is noarch, no C code is included, so > C extension related things are not needed. > (e.g. export CONFIGURE_ARGS=.... writing this on noarch > srpm is confusing) Removed. > * Unneeded files > - > https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/ > Ruby#Running_test_suites > - Current packaging guidelines requests NOT to > ship files under test/ > > - Also, "Rakefile" is something like "Makefile", which > we do not ship in binary rpms. > > - %{gem_instdir}/bicho.gemspec is usually also not needed. I've excluded these files from the package. > > * Executing test > > https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/ > Ruby#Running_test_suites > - As this gem contains test/ directory, please execute > some test suite on %check if possible. If not possible, > please write some comments on the spec file > (e.g. test suite needs network access or so) To run the tests requires BRs for rubygem-nokogiri and rubygem-inifile. This works locally, but won't be buildable via Koji until the git repo is made for rubygem-inifile. Updated SPEC: http://mcpierce.fedorapeople.org/rpms/rubygem-bicho.spec updated SRPM: http://mcpierce.fedorapeople.org/rpms/rubygem-bicho-0.0.6-2.1.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oAjeOwn3n0&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review