Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890417 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #3 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- [!]: Requires correct, justified where necessary. [!]: Package installs properly. Note: Installation errors (see attachment) php-mongo => php-pecl(mongo) I will prefer to not require this optional dependency (pull a lot of stuff) Proposal: remove the requires, and add a comment in package description or create a php-Analog-mongo sub-package (seems a bit ugly for a single file) [!]: Package complies to the Packaging Guidelines I don't understand version, why 1.0.0.1 ? If post release, should be 1.0.0-1.gitxxx If pre release , should be 1.0.0.1-0.1.gitxxx or justify/explain [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. From https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text "Common licenses that require including their texts with all derivative works include ASL 2.0, EPL, BSD and MIT." So open a upstream request and: wait for upstream new release or add the LICENSE to the package sources [!]: %check is present and all tests pass. %check phpunit tests [!]: Rpmlint is run on all installed packages. php-Analog.src: E: specfile-error error: Macro % has illegal name (%define) -%global %reldate 20121224 +%global reldate 20121224 or drop this unused macro. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DuBhQG1yMy&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review