Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885038 --- Comment #12 from Michael Schwendt <mschwendt@xxxxxxxxx> --- Which is what I've just tried, because I was curious to figure out how much effort would be needed to adhere to the Games SIG's packaging guidelines. I had started with adding -DPENTOBI_BOOKS_DIR=%{_datadir}/%{name}/books \ -DPENTOBI_MANUAL_DIR=%{_datadir}/%{name}/manual \ -DPENTOBI_TRANSLATIONS=%{_datadir}/%{name}/translations \ to the cmake invocation in the spec file. Then I built locally with "rpmbuild -bi pentobi.spec" to check what of the %files section would need to be adjusted. For subsequent tests I've modified the files directly in the builddir and ran "rpm --short-circuit -bi pentobi.spec" to reinstall without recompiling. I've had to modify these ./src/books/CMakeLists.txt ./src/pentobi/CMakeLists.txt ./src/pentobi_thumbnailer/CMakeLists.txt ./src/libpentobi_gui/CMakeLists.txt in trivial ways in their "install …" lines, since they contain hardcoded paths and don't use the PENTOBI_* variables defined above. One also cannot install into /usr/bin instead of /usr/games without patching out a hardcoded "games" destination value. Finally, I had to modify the spec to use -DPENTOBI_MANUAL_DIR=%{_datadir}/%{name}/ \ instead, because the cmake files install a full directory "manual" into that directory and ended up with a double "manual/manual/". Shipping a patch upstream for the four CMakeLists.txt files is a package maintenance task that will need to be handled. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HIKoBg8AAr&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review