[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885038

--- Comment #10 from Michael Schwendt <mschwendt@xxxxxxxxx> ---
Simply moving the files in %install will break, because some of the paths get
built/compiled into the program. For example:

  $ grep PENTOBI_ pentobi-5.0/src/* -R|grep DIR
  pentobi-5.0/src/pentobi/Main.cpp:#ifdef PENTOBI_MANUAL_DIR
  pentobi-5.0/src/pentobi/Main.cpp:        manualDir = PENTOBI_MANUAL_DIR;
  pentobi-5.0/src/pentobi/Main.cpp:#ifdef PENTOBI_BOOKS_DIR
  pentobi-5.0/src/pentobi/Main.cpp:        booksDir = PENTOBI_BOOKS_DIR;

For some of those paths, it should be enough to define several of the CMake
variables to use non-default dirs at build-time already. From CMakeLists.txt:

if(NOT DEFINED PENTOBI_BOOKS_DIR)
  if(UNIX AND NOT APPLE)
    set(PENTOBI_BOOKS_DIR
      "${CMAKE_INSTALL_PREFIX}/share/games/pentobi/books")
  endif()
endif()
if(NOT DEFINED PENTOBI_MANUAL_DIR)
  if(UNIX AND NOT APPLE)
    set(PENTOBI_MANUAL_DIR
      "${CMAKE_INSTALL_PREFIX}/share/games/pentobi/manual")
  endif()
endif()
if(NOT DEFINED PENTOBI_TRANSLATIONS)
  if(UNIX AND NOT APPLE)
    set(PENTOBI_TRANSLATIONS
      "${CMAKE_INSTALL_PREFIX}/share/games/pentobi/translations")
  endif()
endif()

For installation of the executables (also the thumbnailer), it looks different.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OBjNi6hlcn&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]