Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=888224 --- Comment #4 from Lorenzo Dalrio <lorenzo.dalrio@xxxxxxxxx> --- (In reply to comment #1) > - I have some dubious about its license; it seems a MIT License has been corrected to MIT. > - Source0 should indicate an entire link to the source package or how it has > been created. > https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL Added a description of how to generate source tarball. > - Description is not correct in my opinion. Better: > > 'This program emulates an AirPort Express for the purpose of streaming music > from iTunes and compatible iPods. It implements a server for the Apple RAOP > protocol. > ShairPort does not support AirPlay v2 (video and photo streaming). > > It supports multiple simultaneous streams, if your audio output chain (as > detected by libao) does so' I have to disagree: the description you pointed out is the one regarding original shairport tool that is not the same as libshairport. > - This line 'rm -rf $RPM_BUILD_ROOT' can be omitted Removed. > - %doc line is empty. Why ? My mistake, %doc line is now populated. I have uploaded corrected version of spec file and srpm, also available on fedorapeople.org: http://lorenzodalrio.fedorapeople.org/libshairport.spec http://lorenzodalrio.fedorapeople.org/libshairport-1.2.1-1.20121218git16395d8.fc17.src.rpm Successful koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4821268 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BDJcTjzSvV&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review