Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882617 --- Comment #8 from Michael Schwendt <mschwendt@xxxxxxxxx> --- jsoncpp.pc : > Cflags: -I${includedir} -I${includedir}/jsoncpp/ The first -I${includedir} should be dropped. It makes no sense, because gcc would ignore it anyway -- and pkg-config drops it, too. ;) jsoncpp.x86_64 : > rpmls jsoncpp|less This base package includes documentation for developers, which should be moved into the -devel package. The package includes only -rwxr-xr-x /usr/lib64/libjsoncpp.so.0.0.0 which is odd, because where is libjsoncpp.so.0? jsoncpp.spec : > %check > scons platform=linux-gcc check %{?_smp_mflags} > # Now, lets make a proper shared lib. :P > g++ -o libjsoncpp.so.0.0.0 -shared -Wl,-soname,libjsoncpp.so.0 > buildscons/linux-gcc-*/src/lib_json/*.os -lpthread I haven't reread the entire spec file, only stumbled into this. The %check section is the entirely wrong place where to build the shared lib. %check is processed _after_ %install, and it does not (and must not) install any files into the %buildroot either. Notice also that here it adds a SONAME, starting with libjsoncpp.so.0 which is rude and dangerous. Upstream really ought to be involved here. How is this handled in the Debian package, which is said to create a shared lib, too? * Just interesting is this upstream bug tracker ticket: File name conflict http://sourceforge.net/tracker/?func=detail&aid=3420553&group_id=144446&atid=758826 Someone points out a previous conflict between jsoncpp and json-c: $ repoquery --whatprovides /usr/include/json/json.h json-c-devel-0:0.10-2.fc18.i686 json-c-devel-0:0.10-2.fc18.x86_64 json-c-devel-0:0.10-2.fc18.i686 json-c-devel-0:0.10-2.fc18.x86_64 For current jsoncpp, the file is stored in another subdir: /usr/include/jsoncpp/json/json.h This is a good example about how easy it is to create conflicts and that it's good to watch out for potential conflicts during review: https://fedoraproject.org/wiki/Packaging:Conflicts#Potential_Conflicting_Files https://fedoraproject.org/wiki/Packaging:Conflicts#Header_Name_Conflicts -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IawsNGAguy&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review