[Bug 823332] Review Request: rubygem-mixlib-log - Ruby mixin for simple log functionality

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=823332

--- Comment #2 from Julian C. Dunn <jdunn@xxxxxxxxxxxx> ---
(In reply to comment #1)
> * There is a newer upstream version out [1]. In Fedora we try to stay with
> the  
>   latest upstream version when possible.
> 
> * Specs should be included in the -doc subpackage
>   Note: specs are already included in the latest version of the gem [1]
> 
> * %check section should ran also other specs that come with the 1.4.1
> 
> * The Ruby runtime dependency needs to be dropped in order to support
> multiple 
>   Ruby implementations in Fedora 19
>   - delete Requires: ruby
> 
> [1] http://rubygems.org/gems/mixlib-log/versions/1.4.1

All done. Please see here for updated spec and SRPM:

http://jdunn.fedorapeople.org/rubygem-mixlib-log/rubygem-mixlib-log.spec
http://jdunn.fedorapeople.org/rubygem-mixlib-log/rubygem-mixlib-log-1.4.1-1.fc19.src.rpm

I had some issues getting the conditional macro to work in %check for EL6
(rspec is too old on EL6 to run the tests). What's in the spec now works, but
it's ugly. Ideally I would just like to do something like

%if %{!?el6}
# run tests in here
%endif

but that didn't work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7Ud2e6FDqH&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]