Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868529 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source tar ball is original (SHA-256: 2beed8af00ae5f87ab62addf7a6d622a91a65d67b26bac097450fbcd23bbae0c). Summary verified from lib/ZMQ/LibZMQ2.pm. Description verified from lib/ZMQ/LibZMQ2.pm. Description verified from lib/ZMQ/LibZMQ2.pm. TODO: You can replace %{__perl} macros with plain perl. TODO: Remove deleting empty directories in %install section. Current build system does not leave empty directories. FIX: Remove bundled inc/* modules or specify all needed dependencies. E.g. Makefile.PL calls use_xshelper from inc/Module/Install/XSUtil.pm that calls use_ppport() which uses Devel::PPPort. TODO: Build-require `perl(base)' (lib/ZMQ/LibZMQ2.pm:3). TODO: Build-require `perl(Exporter)' (lib/ZMQ/LibZMQ2.pm:3). TODO: Build-require `perl(XSLoader)' (lib/ZMQ/LibZMQ2.pm:4). TODO: Build-require `perl(constant)' (lib/ZMQ/LibZMQ2.pm:12). FIX: Build-require `perl(File::Spec)' (t/100_basic.t:3). TODO: Build-require `perl(Storable)' (t/100_basic.t:8). FIX: Build-require `perl(Test::SharedFork)' (t/104_ipc.t:3). TODO: Build-require `perl(File::Temp)' (t/104_ipc.t:4). Proc::Guard is optional. Ok. FIX: Do not (build-)require `perl(Task::Weaken)', it's not needed anywhere. FIX: Do not build-require `perl(Devel::CheckLib)' as it is bundled under inc directory, or unbundle the module. All tests pass. Ok. $ rpmlint perl-ZMQ-LibZMQ2.spec ../SRPMS/perl-ZMQ-LibZMQ2-1.03-1.fc19.src.rpm ../RPMS/x86_64/perl-ZMQ-LibZMQ2-* perl-ZMQ-LibZMQ2.src: W: spelling-error Summary(en_US) libzmq -> Librium perl-ZMQ-LibZMQ2.x86_64: W: spelling-error Summary(en_US) libzmq -> Librium perl-ZMQ-LibZMQ2.x86_64: W: private-shared-object-provides /usr/lib64/perl5/vendor_perl/auto/ZMQ/LibZMQ2/LibZMQ2.so LibZMQ2.so()(64bit) perl-ZMQ-LibZMQ2.x86_64: W: private-shared-object-provides /usr/lib64/perl5/vendor_perl/auto/ZMQ/LibZMQ2/LibZMQ2.so LibZMQ2.so()(64bit) 3 packages and 1 specfiles checked; 0 errors, 4 warnings. FIX: Do not export private library LibZMQ2.so. $ rpm -q -lv -p ../RPMS/x86_64/perl-ZMQ-LibZMQ2-1.03-1.fc19.x86_64.rpm drwxr-xr-x 2 root root 0 Dec 21 12:56 /usr/lib64/perl5/vendor_perl/ZMQ -rw-r--r-- 1 root root 15789 Oct 9 06:54 /usr/lib64/perl5/vendor_perl/ZMQ/LibZMQ2.pm drwxr-xr-x 2 root root 0 Dec 21 12:56 /usr/lib64/perl5/vendor_perl/auto/ZMQ drwxr-xr-x 2 root root 0 Dec 21 12:56 /usr/lib64/perl5/vendor_perl/auto/ZMQ/LibZMQ2 -rwxr-xr-x 1 root root 61552 Dec 21 12:56 /usr/lib64/perl5/vendor_perl/auto/ZMQ/LibZMQ2/LibZMQ2.so drwxr-xr-x 2 root root 0 Dec 21 12:56 /usr/share/doc/perl-ZMQ-LibZMQ2-1.03 -rw-r--r-- 1 root root 2551 Oct 9 06:54 /usr/share/doc/perl-ZMQ-LibZMQ2-1.03/Changes -rw-r--r-- 1 root root 7185 Dec 21 12:56 /usr/share/man/man3/ZMQ::LibZMQ2.3pm.gz File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-ZMQ-LibZMQ2-1.03-1.fc19.x86_64.rpm |sort | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.14)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libzmq.so.1()(64bit) 1 perl(base) 1 perl(constant) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.16.2) 1 perl(strict) 1 perl(Task::Weaken) 1 perl(XSLoader) 1 perl(ZMQ::Constants) 1 perl(ZMQ::Constants) >= 1.00 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) FIX: Do not run-require `perl(Task::Weaken)'. TODO: Do not require unversioned `perl(ZMQ::Constants)'. $ rpm -q --provides -p ../RPMS/x86_64/perl-ZMQ-LibZMQ2-1.03-1.fc19.x86_64.rpm |sort | uniq -c 1 LibZMQ2.so()(64bit) 1 perl(ZMQ::LibZMQ2) = 1.03 1 perl-ZMQ-LibZMQ2 = 1.03-1.fc19 1 perl-ZMQ-LibZMQ2(x86-64) = 1.03-1.fc19 FIX: Do not export private library LibZMQ2.so. $ resolvedeps rawhide ../RPMS/x86_64/perl-ZMQ-LibZMQ2-1.03-1.fc19.x86_64.rpm Binary dependencies resolvable. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4810660). Ok. Otherwise package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' issues, consider fixing `TODO' items, and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JmBktgtc7L&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review