Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887846 --- Comment #4 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source tar ball is original (SHA-256: 72075e4e9883cee51446ba9511264c8c32a015a80f4a5648a3f6b382c534402c). Ok. Summary verified from lib/Math/Geometry/Voronoi.pm. Ok. Description verified from lib/Math/Geometry/Voronoi.pm. Ok. License verified from lib/Math/Geometry/Voronoi.pm, ppport.h, README, Math-Geometry-Voronoi-license-mail1.txt, and Math-Geometry-Voronoi-license-mail2.txt. Ok. This code contains XS code. Architecture specific BuildArch is Ok. Notice: I express a little bit worry about bundling original MIT code, but because it's heavily modified and not packaged in Fedora elsewhere, I do not consider this as bundling. TODO: You can replace %{__perl} macros with plain perl. TODO: Build-require `perl(base)' (lib/Math/Geometry/Voronoi.pm:15). FIX: Build-require `perl(Class::Accessor::Fast)' instead of `perl(Class::Accessor)' (lib/Math/Geometry/Voronoi.pm:15). All tests pass. Ok. $ rpmlint perl-Math-Geometry-Voronoi.spec ../SRPMS/perl-Math-Geometry-Voronoi-1.3-6.fc19.src.rpm ../RPMS/x86_64/perl-Math-Geometry-Voronoi-* perl-Math-Geometry-Voronoi.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-Math-Geometry-Voronoi-1.3/C-LICENSE perl-Math-Geometry-Voronoi.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-Math-Geometry-Voronoi-1.3/license-mail2.txt perl-Math-Geometry-Voronoi-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/Math-Geometry-Voronoi-1.3/memory.c perl-Math-Geometry-Voronoi-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/Math-Geometry-Voronoi-1.3/edgelist.c perl-Math-Geometry-Voronoi-debuginfo.x86_64: E: wrong-script-end-of-line-encoding /usr/src/debug/Math-Geometry-Voronoi-1.3/edgelist.c perl-Math-Geometry-Voronoi-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/Math-Geometry-Voronoi-1.3/output.c perl-Math-Geometry-Voronoi-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/Math-Geometry-Voronoi-1.3/heap.c perl-Math-Geometry-Voronoi-debuginfo.x86_64: E: wrong-script-end-of-line-encoding /usr/src/debug/Math-Geometry-Voronoi-1.3/heap.c perl-Math-Geometry-Voronoi-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/Math-Geometry-Voronoi-1.3/voronoi_main.c perl-Math-Geometry-Voronoi-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/Math-Geometry-Voronoi-1.3/geometry.c perl-Math-Geometry-Voronoi-debuginfo.x86_64: E: wrong-script-end-of-line-encoding /usr/src/debug/Math-Geometry-Voronoi-1.3/geometry.c perl-Math-Geometry-Voronoi-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/Math-Geometry-Voronoi-1.3/voronoi_core.c perl-Math-Geometry-Voronoi-debuginfo.x86_64: E: wrong-script-end-of-line-encoding /usr/src/debug/Math-Geometry-Voronoi-1.3/voronoi_core.c perl-Math-Geometry-Voronoi-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/Math-Geometry-Voronoi-1.3/vdefs.h TODO: Recode C-LICENSE file to have UNIX-style end-of-lines. TODO: Remove executable permission from source files. Otherwise rpmlint is good. $ rpm -q -lv -p ../RPMS/x86_64/perl-Math-Geometry-Voronoi-1.3-6.fc19.x86_64.rpm drwxr-xr-x 2 root root 0 Dec 21 10:31 /usr/lib64/perl5/vendor_perl/Math drwxr-xr-x 2 root root 0 Dec 21 10:31 /usr/lib64/perl5/vendor_perl/Math/Geometry -rw-r--r-- 1 root root 12588 Jul 11 2009 /usr/lib64/perl5/vendor_perl/Math/Geometry/Voronoi.pm -rw-r--r-- 1 root root 486 Jul 11 2009 /usr/lib64/perl5/vendor_perl/Math/Geometry/leak-test.pl drwxr-xr-x 2 root root 0 Dec 21 10:31 /usr/lib64/perl5/vendor_perl/auto/Math drwxr-xr-x 2 root root 0 Dec 21 10:31 /usr/lib64/perl5/vendor_perl/auto/Math/Geometry drwxr-xr-x 2 root root 0 Dec 21 10:31 /usr/lib64/perl5/vendor_perl/auto/Math/Geometry/Voronoi -rwxr-xr-x 1 root root 28008 Dec 21 10:31 /usr/lib64/perl5/vendor_perl/auto/Math/Geometry/Voronoi/Voronoi.so drwxr-xr-x 2 root root 0 Dec 21 10:31 /usr/share/doc/perl-Math-Geometry-Voronoi-1.3 -rw-r--r-- 1 root root 1111 Dec 21 10:31 /usr/share/doc/perl-Math-Geometry-Voronoi-1.3/C-LICENSE -rw-r--r-- 1 root root 606 Jul 11 2009 /usr/share/doc/perl-Math-Geometry-Voronoi-1.3/Changes -rw-r--r-- 1 root root 1220 Jul 11 2009 /usr/share/doc/perl-Math-Geometry-Voronoi-1.3/README -rw-rw-r-- 1 root root 10939 Dec 21 10:08 /usr/share/doc/perl-Math-Geometry-Voronoi-1.3/license-mail1.txt -rw-rw-r-- 1 root root 17427 Dec 21 10:08 /usr/share/doc/perl-Math-Geometry-Voronoi-1.3/license-mail2.txt -rw-r--r-- 1 root root 4417 Dec 21 10:31 /usr/share/man/man3/Math::Geometry::Voronoi.3pm.gz TODO: Remove write permission for group on license-mail*.txt files. TODO: Do not package leak-test.pl. The file is useful for upstream developer only and it's installed by EU::MM mistake. $ rpm -q --requires -p ../RPMS/x86_64/perl-Math-Geometry-Voronoi-1.3-6.fc19.x86_64.rpm |sort |uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.3.4)(64bit) 1 perl >= 0:5.008 1 perl(base) 1 perl(Class::Accessor::Fast) 1 perl(List::Util) 1 perl(:MODULE_COMPAT_5.16.2) 1 perl(Params::Validate) 1 perl(strict) 1 perl(warnings) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-Math-Geometry-Voronoi-1.3-6.fc19.x86_64.rpm |sort |uniq -c 1 perl(Math::Geometry::Voronoi) = 1.3 1 perl-Math-Geometry-Voronoi = 1.3-6.fc19 1 perl-Math-Geometry-Voronoi(x86-64) = 1.3-6.fc19 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-Math-Geometry-Voronoi-1.3-6.fc19.x86_64.rpm Binary dependencies resolvable. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4810244). Ok. Otherwise package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' issues, consider fixing `TODO' items, and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FCIE2tqRff&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review