Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876406 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: $ diff -u perl-Data-Rmap.spec{.old,} --- perl-Data-Rmap.spec.old 2012-12-20 17:27:15.214000000 +0100 +++ perl-Data-Rmap.spec 2012-12-21 09:41:03.688000000 +0100 @@ -1,33 +1,36 @@ Name: perl-Data-Rmap Version: 0.62 -Release: 3%{?dist} +Release: 4%{?dist} Summary: Recursive map, apply a block to a data structure License: GPL+ or Artistic Group: Development/Libraries URL: http://search.cpan.org/dist/Data-Rmap/ Source0: http://www.cpan.org/authors/id/B/BO/BOWMANBS/Data-Rmap-%{version}.tar.gz BuildArch: noarch +BuildRequires: perl(Carp) +BuildRequires: perl(Data::Dumper) +BuildRequires: perl(Exporter) BuildRequires: perl(Module::Build) -BuildRequires: perl(Test::More) +BuildRequires: perl(Scalar::Util) BuildRequires: perl(Test::Exception) -Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) +BuildRequires: perl(Test::More) +Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) %description -Recursively evaluate a BLOCK over a list of data structures -(locally setting $_ to each element) and return the list composed -of the results of such evaluations. $_ can be used to modify +This perl module evaluates a BLOCK over a list of data structures +recursively (locally setting $_ to each element) and return the list +composed of the results of such evaluations. $_ can be used to modify the elements. %prep %setup -q -n Data-Rmap-%{version} %build -%{__perl} Build.PL installdirs=vendor +perl Build.PL installdirs=vendor ./Build %install ./Build install destdir=%{buildroot} create_packlist=0 -find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \; %{_fixperms} %{buildroot}/* @@ -41,6 +44,12 @@ %{_mandir}/man3/* %changelog +* Thu Dec 20 2012 Miro Hrončok <miro@xxxxxxxxxx> - 0.62-4 +- Chnaged the description a bit for better language +- Replaced %%{__perl} with perl +- Removed deleting empty directories in %%install section +- Added BRs for tests + * Fri Nov 16 2012 Miro Hrončok <miro@xxxxxxxxxx> - 0.62-3 - Removed BRs provided by perl package and more > TODO: I think the first sentence of description is not valid English. > Try better word ordering like `This perl module evaluates a BLOCK over > a list of data structures recursively...'. -Recursively evaluate a BLOCK over a list of data structures -(locally setting $_ to each element) and return the list composed -of the results of such evaluations. $_ can be used to modify +This perl module evaluates a BLOCK over a list of data structures +recursively (locally setting $_ to each element) and return the list +composed of the results of such evaluations. $_ can be used to modify the elements. TODO: s/and return the list/and returns the list/ > TODO: You can replace `%{__perl}' macros invocations with plain `perl' in the spec file. Ok. > TODO: Remove deleting empty directories in %install section. Modern Module::Build does not leave empty directories. -find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \; Ok. > FIX: Build-require `perl(Carp)' for running tests (lib/Data/Rmap.pm:392). +BuildRequires: perl(Carp) Ok. > FIX: Build-require `perl(Scalar::Util)' for running tests (lib/Data/Rmap.pm:393). +BuildRequires: perl(Scalar::Util) Ok. > TODO: Build-require `perl(Exporter)' for running tests (lib/Data/Rmap.pm:395). +BuildRequires: perl(Exporter) Ok. > FIX: Build-require `perl(Data::Dumper)' for running tests (test.pl:7). +BuildRequires: perl(Data::Dumper) Ok. All tests pass. Ok. $ rpmlint perl-Data-Rmap.spec ../SRPMS/perl-Data-Rmap-0.62-4.fc19.src.rpm ../RPMS/noarch/perl-Data-Rmap-0.62-4.fc19.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4810202). ??? Package is good. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hqJVLCTBfy&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review