Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ntop - A network traffic probe similar to the UNIX top command https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219025 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-02-20 08:08 EST ------- Well, for 0.2.20060218cvs: * cvs custom - Well, it is a custom when using CVS source to do in %prep stage: ---------------------------------------------------- find . -name CVS | sort -r | xargs rm -rf ---------------------------------------------------- to avoid cvs stuff accidentally installed. * BuildRequires: - On FC-devel, tcp_wrapper-devel is already out (anyway tcp_wrapper-devel is required by net-snmp-devel so this is redundant. However, it is not bad to write explicitly "tcp_wrapper-devel" BuildRequires because configure explicitly requires this for one of the options). You may write ---------------------------------------------------- %if 0%{?fedora} >= 7 Requires: tcp_wrappers-devel %else Requires: tcp_wrappers %endif ---------------------------------------------------- - BR: glib2-devel is redundant. gdome2-devel requires it. * Documentation-seeming files - By the way, are the files under /usr/share/ntop/html always required by this package? Well, I tested Ctrl-C interrupt for about 30 times, and this time segv didn't occur. I want to approve this package after the issues above are resolved and after I check some other issues (which takes some time to be checked). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review