Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876406 --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- Sndalone spec file in spec file from SRPM differ. I will use the newer standalone one for this review. Source tar ball is original (SHA-256: 66686c34dcc32e1fdb6acc1cd6bc55e4b75496c9ca850645a8e3a8953c953c48). Ok. URL and Source0 are Ok. Summary verified from lib/Data/Rmap.pm. Ok. Description verified from lib/Data/Rmap.pm. Ok. TODO: I think the first sentence of description is not valid English. Try better word ordering like `This perl module evaluates a BLOCK over a list of data structures recursively...'. License verified from lib/Data/Rmap.pm. Ok. TODO: You can replace `%{__perl}' macros invocations with plain `perl' in the spec file. TODO: Remove deleting empty directories in %install section. Modern Module::Build does not leave empty directories. No XS code. noarch BuildArch is Ok. FIX: Build-require `perl(Carp)' for running tests (lib/Data/Rmap.pm:392). FIX: Build-require `perl(Scalar::Util)' for running tests (lib/Data/Rmap.pm:393). TODO: Build-require `perl(Exporter)' for running tests (lib/Data/Rmap.pm:395). FIX: Build-require `perl(Data::Dumper)' for running tests (test.pl:7). All tests pass. Ok. $ rpmlint perl-Data-Rmap.spec ../SRPMS/perl-Data-Rmap-0.62-3.fc19.src.rpm ../RPMS/noarch/perl-Data-Rmap-0.62-3.fc19.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Data-Rmap-0.62-3.fc19.noarch.rpm drwxr-xr-x 2 root root 0 Dec 20 17:44 /usr/share/doc/perl-Data-Rmap-0.62 -rw-r--r-- 1 root root 373 Sep 22 2008 /usr/share/doc/perl-Data-Rmap-0.62/Changes -rw-r--r-- 1 root root 10379 Mar 29 2007 /usr/share/doc/perl-Data-Rmap-0.62/README -rw-r--r-- 1 root root 6505 Dec 20 17:44 /usr/share/man/man3/Data::Rmap.3pm.gz drwxr-xr-x 2 root root 0 Dec 20 17:44 /usr/share/perl5/vendor_perl/Data -rw-r--r-- 1 root root 13977 Dec 20 17:44 /usr/share/perl5/vendor_perl/Data/Rmap.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Data-Rmap-0.62-3.fc19.noarch.rpm | sort |uniq -c 1 perl(Carp) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.16.2) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Data-Rmap-0.62-3.fc19.noarch.rpm | sort |uniq -c 1 perl(Data::Rmap) = 0.62 1 perl-Data-Rmap = 0.62-3.fc19 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Data-Rmap-0.62-3.fc19.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4807334). ??? Otherwise package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' issued, consider fixing `TODO' items, and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sKHcC8MZfw&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review