Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876405 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- The standalone spec file is older than the the one from SRPM file. I will use file from SRPM for this review. Source file is original (SHA-256: dd51f9e41b641de535b7073310600f6a04e7466eacc87c2692b0df75d31e5048). Ok. URL and Source0 are usable. Ok. Summary verified from lib/Module/Build/WithXSpp.pm. Ok. Description verified from lib/Module/Build/WithXSpp.pm. Ok. License verified from lib/Module/Build/WithXSpp.pm and README. Ok. No XS code. noarch BuildArch is Ok. TODO: Remove deleting empty directories in %install section. Modern Module::Build does not leave empty directories. TODO: Do not package META.json. It's useful only for this package packager. TODO: Sort (build-)requires lexicographically. It will ease future maintenance. FIX: Remove useless `perl(XSLoader)' (build-)dependency. FIX: Remove useless `perl(Digest::MD5)' (build-)dependency. FIX: Remove useless `perl(ExtUtils::CBuilder)' (build-)dependency. FIX: Remove BuildRequires `perl(ExtUtils::CppGuess)'. It's not needed at build-time. FIX: Remove BuildRequires `perl(ExtUtils::ParseXS))'. It's not needed at build-time. FIX: Remove BuildRequires `perl(ExtUtils::Typemaps)'. It's not needed at build-time. FIX: Remove BuildRequires `perl(ExtUtils::XSpp)'. It's not needed at build-time. All tests pass. Ok. $ rpmlint perl-Module-Build-WithXSpp.spec ../SRPMS/perl-Module-Build-WithXSpp-0.12-1.fc19.src.rpm ../RPMS/noarch/perl-Module-Build-WithXSpp-0.12-1.fc19.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Module-Build-WithXSpp-0.12-1.fc19.noarch.rpm drwxr-xr-x 2 root root 0 Dec 20 16:56 /usr/share/doc/perl-Module-Build-WithXSpp-0.12 -rw-r--r-- 1 root root 1366 Oct 6 11:51 /usr/share/doc/perl-Module-Build-WithXSpp-0.12/Changes -rw-r--r-- 1 root root 1331 Oct 6 11:51 /usr/share/doc/perl-Module-Build-WithXSpp-0.12/META.json -rw-r--r-- 1 root root 9432 Oct 6 11:51 /usr/share/doc/perl-Module-Build-WithXSpp-0.12/README -rw-r--r-- 1 root root 5650 Dec 20 16:55 /usr/share/man/man3/Module::Build::WithXSpp.3pm.gz drwxr-xr-x 2 root root 0 Dec 20 16:56 /usr/share/perl5/vendor_perl/Module drwxr-xr-x 2 root root 0 Dec 20 16:56 /usr/share/perl5/vendor_perl/Module/Build -rw-r--r-- 1 root root 22010 Dec 20 16:55 /usr/share/perl5/vendor_perl/Module/Build/WithXSpp.pm File permissions and layout is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Module-Build-WithXSpp-0.12-1.fc19.noarch.rpm | sort | uniq -c 1 perl(Digest::MD5) 1 perl(ExtUtils::CBuilder) 1 perl(ExtUtils::CppGuess) 1 perl(ExtUtils::CppGuess) >= 0.04 1 perl(ExtUtils::ParseXS) >= 2.2205 1 perl(ExtUtils::Typemaps) >= 1.00 1 perl(ExtUtils::XSpp) >= 0.11 1 perl(File::Basename) 1 perl(File::Spec) 1 perl(Module::Build) 1 perl(Module::Build) >= 0.26 1 perl(:MODULE_COMPAT_5.16.2) 1 perl(strict) 1 perl(warnings) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Remove unneeded `perl(Digest::MD5)', `perl(ExtUtils::CBuilder)', `perl(XSLoader)'. TODO: Filter unversioned `perl(ExtUtils::CppGuess)' run-time dependency. TODO: Filter unversioned `perl(Module::Build)' run-time dependency. $ rpm -q --provides -p ../RPMS/noarch/perl-Module-Build-WithXSpp-0.12-1.fc19.noarch.rpm | sort | uniq -c 1 perl(Module::Build::WithXSpp) = 0.12 1 perl-Module-Build-WithXSpp = 0.12-1.fc19 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Module-Build-WithXSpp-0.12-1.fc19.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4807259). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' issues, consider fixing `TODO' items, and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IZHgYMDTq2&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review