Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875450 --- Comment #5 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> --- - Do you plan to include your package in older EPEL releases? If not, please remove the obsolete stuff (e.g. %defattr, Group:, and %clean). - Please use macros instead of hardcoded path descriptions. Meaning replace /usr/sbin/ with %{_sbindir} and so on. - Please check if the *.la files are needed by the package. https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries - The unversioned shared system library files must go to the -devel package. https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages - man pages do not need to be marked as %doc. - Please give a brief summary of changes in the changelog about the changes you have made. This way it's much easier to follow the development of the spec file. If you are still looking for a sponsor, please follow https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pXOq3HP3tc&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review