Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=884291 --- Comment #4 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- Scratch build for f18: http://koji.fedoraproject.org/koji/taskinfo?taskID=4804369 $ rpmlint -i -v * gvrng.src: I: checking gvrng.src: I: checking-url http://gvr.sourceforge.net (timeout 10 seconds) gvrng.src: I: checking-url http://downloads.sourceforge.net/project/gvr/GvR%20GTK/4.4/GvRng_4.4.tgz (timeout 10 seconds) gvrng.noarch: I: checking gvrng.noarch: I: checking-url http://gvr.sourceforge.net (timeout 10 seconds) gvrng.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/gvrng/gvrng.py 0644L /usr/bin/env This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. gvrng.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/gvrng/gvrng.py The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/14.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/gvrng/start_activity.py The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/01.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/17.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/12.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/gvrng/GvrController.py The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/02.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/gvrng/GvrModel.py The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/gvrng/GPL-2 This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/GPL-2 The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/08.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/04.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/gvrng/utils.py The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/gvrng/gui-gtk/Win_Editors.py The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/gvrng/gui-gtk/fake_sugar_activity.py The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/05.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/gvrng/gui-gtk/Editors.py The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/langref.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/index.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/copyright The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/15.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/10.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/gvrng/gui-gtk/gvr_gtk.py 0644L /usr/bin/env This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. gvrng.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/gvrng/gui-gtk/gvr_gtk.py The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/07.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/16.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/06.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/18.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/13.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/03.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/gvrng/gui-gtk/Widgets.py The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: W: dangling-symlink /usr/lib/python2.7/site-packages/gvrng/docs /usr/share/doc/gvrng The target of the symbolic link does not exist within this package or its file based dependencies. Verify spelling of the link target and that the target is included in a package in this package's dependency chain. gvrng.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/gvrng/gvrparser.py The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/09.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/11.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/gvrng/locale/ca/LC_MESSAGES/gvrng.mo gvrng.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/gvrng/locale/cs/LC_MESSAGES/gvrng.mo gvrng.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/gvrng/locale/de/LC_MESSAGES/gvrng.mo gvrng.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/gvrng/locale/es/LC_MESSAGES/gvrng.mo gvrng.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/gvrng/locale/fr/LC_MESSAGES/gvrng.mo gvrng.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/gvrng/locale/it/LC_MESSAGES/gvrng.mo gvrng.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/gvrng/locale/nl/LC_MESSAGES/gvrng.mo gvrng.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/gvrng/locale/no/LC_MESSAGES/gvrng.mo gvrng.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/gvrng/locale/ro/LC_MESSAGES/gvrng.mo gvrng.spec: I: checking-url http://downloads.sourceforge.net/project/gvr/GvR%20GTK/4.4/GvRng_4.4.tgz (timeout 10 seconds) 2 packages and 1 specfiles checked; 35 errors, 11 warnings. The file /usr/share/doc/gvrng/GPL-2 has a wrong line ending (DOS style). Please correct it. The script gvrng.py resides in %{python_sitelib} and contains a shebang. This is not needed for Python scripts, unless they are in /usr/bin or somewhere else. please remove the shebang. Don't bother with the wronf FSF addresses. Well, you could change them using a sed command, but it's your decision. You are not forced by the packaging guidelines to do so: https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address In any case, you have to inform the upstream people, if possible. The translation files (*.mo) have to be installed using the find_lang macro: http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files ln -s /usr/share/doc/gvrng/ %{buildroot}%{python_sitelib}/gvrng/docs This doesn't work. The hardcoded path has to be replaced with a relative path to %{buildroot}. This application seems to have a Gtk interface. But Gtk is not in the runtime dependencies of the package: $ rpm -qpR gvrng*noarch.rpm /bin/sh python(abi) = 2.7 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 After a first look at the source code, obviously you have to add pygtk2-libglade, maybe some more. Last but not least it is a graphical application, and as such it needs a desktop file: http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=o2q9oy6re5&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review