Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=888598 --- Comment #1 from Mario Ceresa <mrceresa@xxxxxxxxx> --- Hi Jerry, I have a couple of questions: * Why do you especially require gsl-devel%{?_isa}, openfst-devel%{?_isa} in the devel package? Do you think it is appropriate to add a brief comment as requested in http://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires ? * Shouldn't the sonames be 1.0.3 instead of 0.0.0? (/usr/lib64/libngram.so.0.0.0) The rest of the package is fine for me. Please reply to this comment and I'll post the formal review -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0ZPkqv9Vr0&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review