Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874105 --- Comment #9 from Darryl L. Pierce <dpierce@xxxxxxxxxx> --- (In reply to comment #8) > (In reply to comment #7) > > > * Dependency between subpackage. > > > - As said before, usually dependency between subpackage must be > > > _full_ (Epoch)-Version-"Release" and isa specific (i.e. > > > Requires: %{name}%{?_isa} = %{version}-%{release} ) > > > > Done. > > So would you explain why you omit "release" dependency? > (i.e. not %{name}%{?_isa} = %{version}-%{release} but > %{name}%{?_isa} = %{version})) > Omitting %release allows user to update only -devel or some other > subpackage while not updating main package, which may result in > inconsistent state or malfunction (especially when both main > package and subpackages are changed between release). A typo, I thought I had included the -%{version} portion. > > Another point I missed before: > * %filter_setup > - %filter_setup is used, however no filters are actually defined, > so this %filter_setup should not be needed. Removed. Updated SPEC: http://mcpierce.fedorapeople.org/rpms/qpid-proton.spec Updated SRPM: http://mcpierce.fedorapeople.org/rpms/qpid-proton-0.2-2.3.fc17.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4802573 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9hE2l9D2KV&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review