Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887907 --- Comment #4 from Eduardo Echeverria <echevemaster@xxxxxxxxx> --- Hi Liang I'll take the review But first some comments: - Please bump the release number of the spec file on changes and try to write a meaningful changelog entry (So far you have made three changes and these should be reflected in the changelog) https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs - I've seen the patch, and I find that has patched the COPYING file (license) --- a/COPYING +++ b/COPYING @@ -2,7 +2,7 @@ Version 2, June 1991 Copyright (C) 1989, 1991 Free Software Foundation, Inc. - 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA. Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. @@ -305,7 +305,7 @@ the "copyright" line and a pointer to where the full notice is found. You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software - Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA. In the explanation of the common rpmlint issues, can be read in https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address The license file, usually COPYING, must not be patched for legal reasons. Other files can be patched if deemed suitable -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tZnDkNmgUp&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review