Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: tk https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226494 wart@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|wart@xxxxxxxxxx |mmaslano@xxxxxxxxxx Flag|fedora-review? |fedora-review- ------- Additional Comments From wart@xxxxxxxxxx 2007-02-19 23:52 EST ------- rpmlint output: E: tk invalid-soname /usr/lib/libtk8.4.so libtk8.4.so As noted in the Tcl merge review, this is a historical oddity that would probably break lots of stuff if changed. The rpmlint warning can be ignored. W: tk dangerous-command-in-%pre rm It appears that the %pre script attempts to remove a link named /usr/{lib,lib64}/tk8.4. Why does it do this? Is this an attempt to clean up a link that was erroneously made in a previous version of Tk? GOOD ==== * Package named appropriately * Sources matches upstream * Spec file legible and in Am. English * BSD license ok, license file included * Build dependencies ok * No locales * No need for a .desktop file * ldconfig called correctly for libraries in %{_libdir} * Not relocatable * No duplicate %files * No need for -doc subpackage * headers and unversioned .so files in -devel subpackage MUSTFIX ======= * The 'URL:' tag is the -devel package description is redundant; the url defaults to the one specified for the main package. * As mentioned in comment #1, the /usr/share/tk8.4 directory is unowned. The patch in comment #1 will fix it, and simplify the %files section. * Mixed use of $RPM_BUILD_ROOT and %{buildroot}. Choose either one and use it consistently. * Move the %{_mandir}/mann/* man pages out of the -devel subpackage and into the main package; these are man pages for the script-level API, not the C-level API. The %{_mandir}/man3/* man pages can remain in the -devel subpackage. * The TOPDIR=$PWD at the top of %build is unnecessary. Remove it. NOTES ===== * package does not currently build because Tcl is not providing the private header files in /usr/include/tcl-private. This is a bug in the tcl package, not tk. * The summary shouldn't contain the package name. You should drop the 'Tk' from the summary and capitalize the 'g': Graphical toolkit for the Tcl scripting language -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review