Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887907 Eduardo Echeverria <echevemaster@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |echevemaster@xxxxxxxxx --- Comment #1 from Eduardo Echeverria <echevemaster@xxxxxxxxx> --- Hi Liang: - Don't need (-n %{name}-%{version}) in the %setup, - Please write a detailed list (one per line) of the BuildRequires - Remove rm -rf $RPM_BUILD_ROOT of the %install (This only applies to packages epel5) - Remove section %clean (The %clean section is not required for F-13 and above.) - Remove %defattr(-,root,root,-) (This only applies to packages epel5) Now let's review the output rpmlint fcitx-anthy-0.1.1-1.fc17.src.rpm fcitx-anthy-0.1.1-1.fc17.x86_64.rpm fcitx-anthy-debuginfo-0.1.1-1.fc17.x86_64.rpm - Please, be consistent between the tag release and the changelog fcitx-anthy.x86_64: W: incoherent-version-in-changelog 0.1.2-1 ['0.1.1-1.fc17', '0.1.1-1'] - FSF postal address is wrong: Please contact the upstream , to correct it. https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/nicola-f.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/doc/fcitx-anthy-0.1.1/COPYING fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/msime.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/tron-dvorak.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/vje-delta.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/canna.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/nicola-j.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/oasys100j.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/tsuki-2-203-106.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/tsuki-2-203-101.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/azik.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/101kana.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/tron-qwerty-jp.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/atok.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/wnn.sty fcitx-anthy.x86_64: E: incorrect-fsf-address /usr/share/fcitx/anthy/nicola-a.sty -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MC2tbMEEZU&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review