Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=883512 --- Comment #5 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> --- (In reply to comment #1) > - In the devel subpackage %{name} = %{version}-%{release} has to be > %{name}%{?_isa} = %{version}-%{release} to match the correct architecture Fixed > - The python bindings subpackage should be renamed to python3-forensic1394. > - in the README can be read Changed > "Python language bindings are provided in the python/ directory and > are compatible with all versions of Python since 2.5 (including > Python 3)" > so it should provide a subpackage built with python2-devel in addition to > the existing python3 bindings Python2 subpackage added > - although the subpackage devel included documentation and not the main one. > there's a lot of documentation, (358400 bytes in 49 files), IMO I consider > should be putting it into a -doc subpackage. > > - The "Provides" of python bindings subpackage, it is not picked up > automatically while building the package Fixed (In reply to comment #2) > > %files > > %doc AUTHORS COPYING COPYING.LESSER README > > > %files devel > > %doc COPYING COPYING.LESSER docs/docs/html > > >%files -n python-%{s_name} > > %doc COPYING COPYING.LESSER fixed Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4798095 rpmlint output: [fab@laptop11 SRPMS]$ rpmlint libforensic1394-0.2-2.fc17.src.rpm libforensic1394.src: W: spelling-error Summary(en_US) firewire -> fire wire, fire-wire, firewater 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [fab@laptop11 x86_64]$ rpmlint *forensic* libforensic1394.x86_64: W: spelling-error Summary(en_US) firewire -> fire wire, fire-wire, firewater python2-forensic1394.x86_64: W: no-documentation python3-forensic1394.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 3 warnings. %changelog * Mon Dec 10 2012 Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> - 0.2-2 - python2 package added - -devel subpackage requires: fixed - License files from the subpackages removed - python 3 subpackage renamed - Docs generation changed Updated files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/libforensic1394.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/libforensic1394-0.2-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EnOVhrVPlZ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review