Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874105 --- Comment #7 from Darryl L. Pierce <dpierce@xxxxxxxxxx> --- (In reply to comment #6) > For -2.1: > > * Versioning > - Please don't use ".1" for release unless needed. > Please use just integer (and %{?dist}) > c.f. > > https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning I'm following the pattern lower down where point releases are mentioned. > * Dependency between subpackage. > - As said before, usually dependency between subpackage must be > _full_ (Epoch)-Version-"Release" and isa specific (i.e. > Requires: %{name}%{?_isa} = %{version}-%{release} ) Done. > * Directory ownership issue > - %{_includedir} itself is already owned by filesystem and > should not be owned by qpid-proton-devel. Oops, done. > * Enabling test suite > - I missed this before, however as the source tarball > contains tests/ directory, please do some tests > in %check if possible. The tests require, ATM, a little bit of setup in order to run them. I'll take upstream a request to make tests easier to run in the packaging environment Update SPEC: http://mcpierce.fedorapeople.org/rpms/qpid-proton.spec Updated SRPM: http://mcpierce.fedorapeople.org/rpms/qpid-proton-0.2-2.2.fc17.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4796610 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RpchRQRFlG&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review