Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877403 --- Comment #29 from Ismael Olea <ismael@xxxxxxxx> --- (In reply to comment #26) > > Other MUST issues: > > - exit 1 in %prep when unxepected jars or class files found (as per > Stanislav' comment) fixed > - You only need to install the license file once if the sub-package > requires the base-package where it is present. fixed > - A simply comment explaining the license breakdown I did it with: # just in SRPM due to nailgun.jar comes included in svnkit sources: Source3: LICENSE-2.0.txt is it not clear enough? :-m > - Your commented link to the maven pom is wrong. IF you haven't edited the > pm file there's no reason why you can't just use the direct link for Source1: It's edited, but fixed the URL > - remove bindir comment in %files section fixed http://olea.org/tmp/omegat-fedora-feature/svnkit.spec http://olea.org/tmp/omegat-fedora-feature/svnkit-1.7.6-4.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oERY8MNVcp&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review