Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877765 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #4 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Spec file changes: -Source1: https://raw.github.com/hroncok/RPMAdditionalSources/master/Math-Libm-license.txt +Source1: Math-Libm-license.txt > FIX: Put the license file to git repository instead of downloading from your > github (like at perl-PDF-Create) Ok +BuildRequires: perl(AutoLoader) +BuildRequires: perl(Carp) +BuildRequires: perl(Exporter) > FIX: Add missing BRs Ok -make pure_install PERL_INSTALL_ROOT=%{buildroot} +make pure_install DESTDIR=%{buildroot} > TODO: Replace variable PERL_INSTALL_ROOT obsoleted with DESTDIR name > in %install. Ok. -find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \; > TODO: Remove the deleting empty directories in %install section. This is > default behavior. Ok Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Z3u62M9cJR&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review