Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823338 --- Comment #11 from Julian C. Dunn <jdunn@xxxxxxxxxxxx> --- (In reply to comment #6) > Jonas, first of all, have you considered to replace moneta by juno [1] or > something similar? I would say that this package is unmaintained by upstream > and should not get into Fedora. > > Otherwise, a few comments: > > * Please drop the "Requires: ruby" > - Since we are going to share gems between JRuby and Ruby in F19, it would > pull in MRI even if not needed. > > * Test suite > - I guess the test suite was developed for RSpec 1.x while you are trying > to > run it with RSpec 2.x. The shared examples are typically troublesome. > - I am not going to dig more into it, but would you please mind to keep the > disabled %check section with appropriate comment in .spec file? It would > help during future updates (if there every will be some) to easily > uncomment > and see what is the state of test suite. I have fixed these in the latest SPEC and SRPM on my fedorapeople page. http://fedorapeople.org/~jdunn/rubygem-moneta/rubygem-moneta-0.6.0-3.fc19.src.rpm http://fedorapeople.org/~jdunn/rubygem-moneta/rubygem-moneta.spec Everything is in the spec to run the tests if they ever get fixed, but the %check section is commented out with an explanation. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BXZd1LXJEi&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review